[alsa-devel] [PATCH] ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE
Fix the following warning during kernel boot:
0-000a: 850 <--> 1600 mV at 1200 mV normal 0-000a: Voltage range but no REGULATOR_CHANGE_VOLTAGE
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- sound/soc/codecs/sgtl5000.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 8e92fb8..bad5ba5 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -87,7 +87,8 @@ static struct regulator_init_data ldo_init_data = { .min_uV = 850000, .max_uV = 1600000, .valid_modes_mask = REGULATOR_MODE_NORMAL, - .valid_ops_mask = REGULATOR_CHANGE_STATUS, + .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE | + REGULATOR_CHANGE_STATUS, }, .num_consumer_supplies = 1, .consumer_supplies = &ldo_consumer[0],
On Tue, Apr 03, 2012 at 05:02:33PM -0300, Fabio Estevam wrote:
Fix the following warning during kernel boot:
0-000a: 850 <--> 1600 mV at 1200 mV normal 0-000a: Voltage range but no REGULATOR_CHANGE_VOLTAGE
Are you sure this is the best fix? There's no set_voltage() call in the driver.
On Tue, Apr 3, 2012 at 5:37 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Tue, Apr 03, 2012 at 05:02:33PM -0300, Fabio Estevam wrote:
Fix the following warning during kernel boot:
0-000a: 850 <--> 1600 mV at 1200 mV normal 0-000a: Voltage range but no REGULATOR_CHANGE_VOLTAGE
Are you sure this is the best fix? There's no set_voltage() call in the driver.
Sorry, I was not able to understand your last comment.
How do you suggest me to fix this, please?
On Tue, Apr 03, 2012 at 05:43:20PM -0300, Fabio Estevam wrote:
On Tue, Apr 3, 2012 at 5:37 PM, Mark Brown
Are you sure this is the best fix? There's no set_voltage() call in the driver.
Sorry, I was not able to understand your last comment.
How do you suggest me to fix this, please?
I was wondering if it might be better to remove the voltage range if the driver doesn't ever actually set the voltage rather than adding an unused permission to change it.
participants (2)
-
Fabio Estevam -
Mark Brown