[alsa-devel] [PATCH 2/4] ASoC: dapm: Refactor the code in snd_soc_dapm_new_pcm
From: anish kumar yesanishhere@gmail.com
refactor snd_soc_dapm_new_pcm to reduce the size of this function to facilitate further refactoring.
Signed-off-by: anish kumar yesanishhere@gmail.com --- sound/soc/soc-dapm.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index f51f613..d55cac6 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -3821,19 +3821,15 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card, devm_kasprintf(card->dev, GFP_KERNEL, "Anonymous Configuration %d", count); - if (!w_param_text[count]) { - ret = -ENOMEM; - goto outfree_link_name; - } } else { w_param_text[count] = devm_kmemdup(card->dev, config->stream_name, strlen(config->stream_name) + 1, GFP_KERNEL); - if (!w_param_text[count]) { - ret = -ENOMEM; - goto outfree_link_name; - } + } + if (!w_param_text[count]) { + ret = -ENOMEM; + goto outfree_link_name; } config++; } -- 2.5.4 (Apple Git-61)
On Thu, Sep 14, 2017 at 10:02:40PM -0700, anish kumar wrote:
From: anish kumar yesanishhere@gmail.com
refactor snd_soc_dapm_new_pcm to reduce the size of this function to facilitate further refactoring.
This doesn't apply against current code, please check and resend.
participants (2)
-
anish kumar
-
Mark Brown