[alsa-devel] [PATCH] ASoC: meson: fix do_div warning in spdifin
Even if this spdif input driver is only supposed to be used on 64bits platform, there is possible problem with 32bits and do_div, as reported by the kbuild robot. Just fix it.
Fixes: 5ce5658375e6 ("ASoC: meson: add axg spdif input") Signed-off-by: Jerome Brunet jbrunet@baylibre.com ---
Hi Mark,
This fixes the problem reported by kbuild robot [0]. Sorry for not catching this earlier.
Regards Jerome
[0]: https://lkml.kernel.org/r/201812132245.lBYydcs3%fengguang.wu@intel.com
sound/soc/meson/axg-spdifin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/meson/axg-spdifin.c b/sound/soc/meson/axg-spdifin.c index 09f385a2bbba..01b2035fa841 100644 --- a/sound/soc/meson/axg-spdifin.c +++ b/sound/soc/meson/axg-spdifin.c @@ -146,8 +146,8 @@ static void axg_spdifin_write_mode_param(struct regmap *map, int mode, unsigned int base_reg, unsigned int width) { - unsigned int offset = mode, rem; - unsigned int reg, shift; + uint64_t offset = mode; + unsigned int reg, shift, rem;
rem = do_div(offset, num_per_reg);
The patch
ASoC: meson: fix do_div warning in spdifin
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 165be3c260f88a5f8c55d89458ad1f1d9efd701f Mon Sep 17 00:00:00 2001
From: Jerome Brunet jbrunet@baylibre.com Date: Thu, 13 Dec 2018 16:44:28 +0100 Subject: [PATCH] ASoC: meson: fix do_div warning in spdifin
Even if this spdif input driver is only supposed to be used on 64bits platform, there is possible problem with 32bits and do_div, as reported by the kbuild robot. Just fix it.
Fixes: 5ce5658375e6 ("ASoC: meson: add axg spdif input") Signed-off-by: Jerome Brunet jbrunet@baylibre.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/meson/axg-spdifin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/meson/axg-spdifin.c b/sound/soc/meson/axg-spdifin.c index 09f385a2bbba..01b2035fa841 100644 --- a/sound/soc/meson/axg-spdifin.c +++ b/sound/soc/meson/axg-spdifin.c @@ -146,8 +146,8 @@ static void axg_spdifin_write_mode_param(struct regmap *map, int mode, unsigned int base_reg, unsigned int width) { - unsigned int offset = mode, rem; - unsigned int reg, shift; + uint64_t offset = mode; + unsigned int reg, shift, rem;
rem = do_div(offset, num_per_reg);
participants (2)
-
Jerome Brunet
-
Mark Brown