[alsa-devel] [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
Hi Mark, Liam,
This patch is to fix an bug that I found in K3.5-rc1. As the IEC-60958 channel status word is not initialized in hw_params, the params from previous calls corrupt those of the current playback.
BR
Ricardo
Ricardo Neri (1): ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
sound/soc/omap/omap-hdmi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
As the IEC-60958 channel status word is set by ANDing and ORing with the appropriate definitions, the word bytes need to be initialized to zero to avoid corruption due to previous hw_params calls.
Signed-off-by: Ricardo Neri ricardo.neri@ti.com --- sound/soc/omap/omap-hdmi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c index a08245d..24b40bd 100644 --- a/sound/soc/omap/omap-hdmi.c +++ b/sound/soc/omap/omap-hdmi.c @@ -108,6 +108,8 @@ static int omap_hdmi_dai_hw_params(struct snd_pcm_substream *substream, /* * fill the IEC-60958 channel status word */ + /* initialize the word bytes */ + memset(iec->status, 0, sizeof(iec->status));
/* specify IEC-60958-3 (commercial use) */ iec->status[0] &= ~IEC958_AES0_PROFESSIONAL;
On Mon, Jun 04, 2012 at 02:07:16PM -0500, Ricardo Neri wrote:
As the IEC-60958 channel status word is set by ANDing and ORing with the appropriate definitions, the word bytes need to be initialized to zero to avoid corruption due to previous hw_params calls.
Acked-by: Mark Brown broonie@opensource.wolfsonmicro.com
On Mon, Jun 04, 2012 at 02:07:15PM -0500, Ricardo Neri wrote:
Hi Mark, Liam,
This patch is to fix an bug that I found in K3.5-rc1. As the IEC-60958 channel status word is not initialized in hw_params, the params from previous calls corrupt those of the current playback.
Don't send cover letters for single patches, if there's anything useful to say say it in the patch.
Hi Mark, On 06/05/2012 05:28 AM, Mark Brown wrote:
On Mon, Jun 04, 2012 at 02:07:15PM -0500, Ricardo Neri wrote:
Hi Mark, Liam,
This patch is to fix an bug that I found in K3.5-rc1. As the IEC-60958 channel status word is not initialized in hw_params, the params from previous calls corrupt those of the current playback.
Don't send cover letters for single patches, if there's anything useful to say say it in the patch.
Sorry, I will resend as a single patch without the cover letter.
Ricardo
participants (2)
-
Mark Brown -
Ricardo Neri