[alsa-devel] [PATCH] SoC: wm8991: Remove unused pointer in wm8991_probe()
Remove unused pointer 'wm8991' in function wm8991_probe(). The last user vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)
Detected by Coverity: CID 1162831
Signed-off-by: Christian Engelmayer cengelma@gmx.at --- sound/soc/codecs/wm8991.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/wm8991.c b/sound/soc/codecs/wm8991.c index dba0306..244eb09 100644 --- a/sound/soc/codecs/wm8991.c +++ b/sound/soc/codecs/wm8991.c @@ -1251,11 +1251,8 @@ static int wm8991_remove(struct snd_soc_codec *codec)
static int wm8991_probe(struct snd_soc_codec *codec) { - struct wm8991_priv *wm8991; int ret;
- wm8991 = snd_soc_codec_get_drvdata(codec); - ret = snd_soc_codec_set_cache_io(codec, 8, 16, SND_SOC_REGMAP); if (ret < 0) { dev_err(codec->dev, "Failed to set cache i/o: %d\n", ret);
On Tue, Feb 04, 2014 at 09:20:59PM +0100, Christian Engelmayer wrote:
Remove unused pointer 'wm8991' in function wm8991_probe(). The last user vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)
Detected by Coverity: CID 1162831
This doesn't apply against current code, please check and resend and please also remember to CC maintainers on patches.
Remove unused pointer 'wm8991' in function wm8991_probe(). The last user vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)
Detected by Coverity: CID 1162831
Signed-off-by: Christian Engelmayer cengelma@gmx.at --- v2: Resend after input by Mark Brown
* Added ASoC maintainer CC. * Added driver maintainer CC. * Verified that the patch applies against v3.14-rc1 as well as branch for-next in git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git. * Fixed a typo in the summary phrase. --- sound/soc/codecs/wm8991.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/wm8991.c b/sound/soc/codecs/wm8991.c index dba0306..244eb09 100644 --- a/sound/soc/codecs/wm8991.c +++ b/sound/soc/codecs/wm8991.c @@ -1251,11 +1251,8 @@ static int wm8991_remove(struct snd_soc_codec *codec)
static int wm8991_probe(struct snd_soc_codec *codec) { - struct wm8991_priv *wm8991; int ret;
- wm8991 = snd_soc_codec_get_drvdata(codec); - ret = snd_soc_codec_set_cache_io(codec, 8, 16, SND_SOC_REGMAP); if (ret < 0) { dev_err(codec->dev, "Failed to set cache i/o: %d\n", ret);
On Fri, Feb 07, 2014 at 07:43:19PM +0100, Christian Engelmayer wrote:
Remove unused pointer 'wm8991' in function wm8991_probe(). The last user vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)
Detected by Coverity: CID 1162831
Applied, thanks.
participants (2)
-
Christian Engelmayer
-
Mark Brown