[alsa-devel] [PATCH][next] ALSA: firewire-lib: remove redundant assignment to cip_header
From: Colin Ian King colin.king@canonical.com
The assignement to cip_header is redundant as the value never read and it is being re-assigned in the if and else paths of the following if statement. Clean up the code by removing it.
Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King colin.king@canonical.com --- sound/firewire/amdtp-stream.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index 2d9c764061d1..4236955bbf57 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -675,7 +675,6 @@ static int handle_in_packet(struct amdtp_stream *s, unsigned int cycle, return -EIO; }
- cip_header = ctx_header + 2; if (!(s->flags & CIP_NO_HEADER)) { cip_header = &ctx_header[2]; err = check_cip_header(s, cip_header, payload_length,
Hi Colin,
On Sat, May 25, 2019, at 06:35, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
The assignement to cip_header is redundant as the value never read and it is being re-assigned in the if and else paths of the following if statement. Clean up the code by removing it.
Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King colin.king@canonical.com
sound/firewire/amdtp-stream.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index 2d9c764061d1..4236955bbf57 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -675,7 +675,6 @@ static int handle_in_packet(struct amdtp_stream *s, unsigned int cycle, return -EIO; }
- cip_header = ctx_header + 2; if (!(s->flags & CIP_NO_HEADER)) { cip_header = &ctx_header[2]; err = check_cip_header(s, cip_header, payload_length,
Thanks for the fix. I've already posted further patch for refactoring and this was also fixed by a commit 98e3e43b599d (" ALSA: firewire-lib: refactoring to obsolete IR packet handler").
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=9...
Thanks
Takashi Sakamoto
participants (2)
-
Colin King -
Takashi Sakamoto