[PATCH][LINUX][ALSA][USB AUDIO CLASS 1] wrong channel ids for surround
Hi,
In the USB audio class 1 specifications, page 33 (3.7.2.3 Audio Channel Cluster Format):
Surround is spatially defined as [rear], hence left surround should be SNDRV_CHMAP_RL and not SND_CHMAP_SL (Side). Same for right surround channel.
Right?
I am not a mailing list subscriber, CC me please.
regards,
On Thu, 25 Jul 2024 13:08:20 +0200, Sylvain BERTRAND wrote:
Hi,
In the USB audio class 1 specifications, page 33 (3.7.2.3 Audio Channel Cluster Format):
Surround is spatially defined as [rear], hence left surround should be SNDRV_CHMAP_RL and not SND_CHMAP_SL (Side). Same for right surround channel.
Right?
Yes, this looks rather like a typo, SL/SR appear twice there.
I am not a mailing list subscriber, CC me please.
regards,
Could you submit a properly formatted patch (with a patch description and your Signed-off-by tag) to linux-sound ML (linux-sound@vger.kernel.org) instead?
thanks,
Takashi
-- Sylvain BERTRAND
--- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -244,8 +244,8 @@ static struct snd_pcm_chmap_elem *convert_chmap(int channels, unsigned int bits, SNDRV_CHMAP_FR, /* right front */ SNDRV_CHMAP_FC, /* center front */ SNDRV_CHMAP_LFE, /* LFE */
SNDRV_CHMAP_SL, /* left surround */SNDRV_CHMAP_SR, /* right surround */
SNDRV_CHMAP_RL, /* left surround */SNDRV_CHMAP_RR, /* right surround */
On Wed, Jul 31, 2024 at 11:26:38AM +0200, Takashi Iwai wrote:
Could you submit a properly formatted patch (with a patch description and your Signed-off-by tag) to linux-sound ML (linux-sound@vger.kernel.org) instead?
Hi,
I tried to send that patch to the lkml, but some admins removed grey listing and I use a domestic smtp server (with DNS SPF though), then I was blocked.
(I don't use only noscript/basic (x)html browsers, then "Big Tech" email services are not available for me)
(I have a github account, and github is still working with noscript/basic (x)html... as for now... then I did report an issue there)
If you have time and accept to do it, I don't mind you or somebody else doing that on my behalf. What matters is this being fixed I guess.
best regards,
On Wed, 31 Jul 2024 16:06:03 +0200, Sylvain BERTRAND wrote:
On Wed, Jul 31, 2024 at 11:26:38AM +0200, Takashi Iwai wrote:
Could you submit a properly formatted patch (with a patch description and your Signed-off-by tag) to linux-sound ML (linux-sound@vger.kernel.org) instead?
Hi,
I tried to send that patch to the lkml, but some admins removed grey listing and I use a domestic smtp server (with DNS SPF though), then I was blocked.
(I don't use only noscript/basic (x)html browsers, then "Big Tech" email services are not available for me)
(I have a github account, and github is still working with noscript/basic (x)html... as for now... then I did report an issue there)
If you have time and accept to do it, I don't mind you or somebody else doing that on my behalf. What matters is this being fixed I guess.
OK, as the fix is trivial, I'll submit and merge it.
thanks,
Takashi
participants (2)
-
Sylvain BERTRAND -
Takashi Iwai