RE: [PATCH v3 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC

5 Mar
2025
5 Mar
'25
10:13 a.m.
- prefix_name:
No underscores in node names, missing vendor prefix... but more important: I don't understand the need for this property. Description copies property name so it is not useful.
And these comments as well.
The prefix_name is used to distinguish the dapm and kcontrol of each individual codec. And I will update name of the property
- everest,dmic-enabled:
- $ref: /schemas/types.yaml#/definitions/flag
- description:
The property is a choice between PDM and AMIC
No supplies?
I will drop the property
I did not comment about dmic, but meant missing power supplies, which usually are placed here.
I apologize for misunderstanding your comment. But we don't have properties about the power supplies
53
Age (days ago)
53
Last active (days ago)
0 comments
1 participants
participants (1)
-
Zhang Yi