[alsa-devel] ASoC updates for 2.6.34
The following changes since your topic/asoc branch are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.34
Since they include (via the 2.6.33 merge) a merge of Linus' tree I've only included the changes that aren't already in your tree or mainline in the summary below, though it looks like the diffstat picked up some extra changes due to the way I tried to do that.
Barry Song (4): ASoC: ad1836: reset and restore clock control mode in suspend/resume entry ASoC: ad1938: fix typo, rename mask to rx_mask for ad1938_set_tdm_slot ASoC: ad1938: let soc-core dapm handle PLL power ASoC: soc-cache: cleanup training whitespace and coding style
Ilkka Koskinen (2): ASoc: tpa6130a2: Remove unnecessary variable ASoC: tpa6130a2: Support for tpa6140's regulators
Kuninori Morimoto (3): ASoC: fsi: Add over_period flag to prevent the misunderstanding ASoC: fsi: Add fsi_get_dai to get snd_soc_dai ASoC: fsi: Add over/under run error settlement
Mark Brown (9): ASoC: Remove unneeded suspend checks from CODEC drivers ASoC: Use snprintf() when generating stream names ASoC: Fix variable shadowing warning in TLV320AIC3x ASoC: Only restore non-default registers for WM8731 ASoC: Only restore non-default registers for WM8776 ASoC: Only restore non-default registers for WM8961 ASoC: Implement suspend and resume for WM8993 ASoC: Fix WM8350 DSP mode B configuration Merge branch 'for-2.6.33' into for-2.6.34
Peter Ujfalusi (5): ASoC: tlv320dac33: Change nsample switch to FIFO mode enum ASoC: tlv320dac33: Introduce prefill and playback state handlers ASoC: tlv320dac33: Clean up the hardware configuration code ASoC: tlv320dac33: Add new FIFO mode: mode 7 ASoC: tlv320dac33: Safety check for codec slave mode
include/sound/soc.h | 3 + include/sound/tpa6130a2-plat.h | 6 + include/sound/wm8904.h | 57 + include/sound/wm8955.h | 26 + sound/soc/codecs/Kconfig | 12 + sound/soc/codecs/Makefile | 10 +- sound/soc/codecs/ad1836.c | 32 + sound/soc/codecs/ad1938.c | 64 +- sound/soc/codecs/cs4270.c | 43 +- sound/soc/codecs/da7210.c | 589 +++++++++ sound/soc/codecs/da7210.h | 24 + sound/soc/codecs/tlv320aic3x.c | 75 +- sound/soc/codecs/tlv320dac33.c | 282 ++++- sound/soc/codecs/tpa6130a2.c | 109 ++- sound/soc/codecs/wm8350.c | 2 +- sound/soc/codecs/wm8727.c | 66 +- sound/soc/codecs/wm8731.c | 3 + sound/soc/codecs/wm8753.c | 8 - sound/soc/codecs/wm8776.c | 2 + sound/soc/codecs/wm8904.c | 2556 +++++++++++++++++++++++++++++++++++++ sound/soc/codecs/wm8904.h | 1681 ++++++++++++++++++++++++ sound/soc/codecs/wm8955.c | 1151 +++++++++++++++++ sound/soc/codecs/wm8955.h | 489 +++++++ sound/soc/codecs/wm8961.c | 3 + sound/soc/codecs/wm8990.c | 8 - sound/soc/codecs/wm8993.c | 67 + sound/soc/davinci/davinci-mcasp.c | 18 +- sound/soc/davinci/davinci-mcasp.h | 1 + sound/soc/davinci/davinci-pcm.c | 2 +- sound/soc/s3c24xx/s3c64xx-i2s.c | 120 +-- sound/soc/sh/Kconfig | 8 + sound/soc/sh/Makefile | 2 + sound/soc/sh/fsi-da7210.c | 83 ++ sound/soc/sh/fsi.c | 164 ++- sound/soc/soc-cache.c | 2 +- sound/soc/soc-core.c | 11 +- sound/soc/soc-dapm.c | 37 +- 37 files changed, 7457 insertions(+), 359 deletions(-) create mode 100644 include/sound/wm8904.h create mode 100644 include/sound/wm8955.h create mode 100644 sound/soc/codecs/da7210.c create mode 100644 sound/soc/codecs/da7210.h create mode 100644 sound/soc/codecs/wm8904.c create mode 100644 sound/soc/codecs/wm8904.h create mode 100644 sound/soc/codecs/wm8955.c create mode 100644 sound/soc/codecs/wm8955.h create mode 100644 sound/soc/sh/fsi-da7210.c
At Tue, 12 Jan 2010 13:20:02 +0000, Mark Brown wrote:
The following changes since your topic/asoc branch are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.34
Since they include (via the 2.6.33 merge) a merge of Linus' tree I've only included the changes that aren't already in your tree or mainline in the summary below, though it looks like the diffstat picked up some extra changes due to the way I tried to do that.
Pulled now. I'm going to check cross-build tests. Thanks.
Takashi
Barry Song (4): ASoC: ad1836: reset and restore clock control mode in suspend/resume entry ASoC: ad1938: fix typo, rename mask to rx_mask for ad1938_set_tdm_slot ASoC: ad1938: let soc-core dapm handle PLL power ASoC: soc-cache: cleanup training whitespace and coding style
Ilkka Koskinen (2): ASoc: tpa6130a2: Remove unnecessary variable ASoC: tpa6130a2: Support for tpa6140's regulators
Kuninori Morimoto (3): ASoC: fsi: Add over_period flag to prevent the misunderstanding ASoC: fsi: Add fsi_get_dai to get snd_soc_dai ASoC: fsi: Add over/under run error settlement
Mark Brown (9): ASoC: Remove unneeded suspend checks from CODEC drivers ASoC: Use snprintf() when generating stream names ASoC: Fix variable shadowing warning in TLV320AIC3x ASoC: Only restore non-default registers for WM8731 ASoC: Only restore non-default registers for WM8776 ASoC: Only restore non-default registers for WM8961 ASoC: Implement suspend and resume for WM8993 ASoC: Fix WM8350 DSP mode B configuration Merge branch 'for-2.6.33' into for-2.6.34
Peter Ujfalusi (5): ASoC: tlv320dac33: Change nsample switch to FIFO mode enum ASoC: tlv320dac33: Introduce prefill and playback state handlers ASoC: tlv320dac33: Clean up the hardware configuration code ASoC: tlv320dac33: Add new FIFO mode: mode 7 ASoC: tlv320dac33: Safety check for codec slave mode
include/sound/soc.h | 3 + include/sound/tpa6130a2-plat.h | 6 + include/sound/wm8904.h | 57 + include/sound/wm8955.h | 26 + sound/soc/codecs/Kconfig | 12 + sound/soc/codecs/Makefile | 10 +- sound/soc/codecs/ad1836.c | 32 + sound/soc/codecs/ad1938.c | 64 +- sound/soc/codecs/cs4270.c | 43 +- sound/soc/codecs/da7210.c | 589 +++++++++ sound/soc/codecs/da7210.h | 24 + sound/soc/codecs/tlv320aic3x.c | 75 +- sound/soc/codecs/tlv320dac33.c | 282 ++++- sound/soc/codecs/tpa6130a2.c | 109 ++- sound/soc/codecs/wm8350.c | 2 +- sound/soc/codecs/wm8727.c | 66 +- sound/soc/codecs/wm8731.c | 3 + sound/soc/codecs/wm8753.c | 8 - sound/soc/codecs/wm8776.c | 2 + sound/soc/codecs/wm8904.c | 2556 +++++++++++++++++++++++++++++++++++++ sound/soc/codecs/wm8904.h | 1681 ++++++++++++++++++++++++ sound/soc/codecs/wm8955.c | 1151 +++++++++++++++++ sound/soc/codecs/wm8955.h | 489 +++++++ sound/soc/codecs/wm8961.c | 3 + sound/soc/codecs/wm8990.c | 8 - sound/soc/codecs/wm8993.c | 67 + sound/soc/davinci/davinci-mcasp.c | 18 +- sound/soc/davinci/davinci-mcasp.h | 1 + sound/soc/davinci/davinci-pcm.c | 2 +- sound/soc/s3c24xx/s3c64xx-i2s.c | 120 +-- sound/soc/sh/Kconfig | 8 + sound/soc/sh/Makefile | 2 + sound/soc/sh/fsi-da7210.c | 83 ++ sound/soc/sh/fsi.c | 164 ++- sound/soc/soc-cache.c | 2 +- sound/soc/soc-core.c | 11 +- sound/soc/soc-dapm.c | 37 +- 37 files changed, 7457 insertions(+), 359 deletions(-) create mode 100644 include/sound/wm8904.h create mode 100644 include/sound/wm8955.h create mode 100644 sound/soc/codecs/da7210.c create mode 100644 sound/soc/codecs/da7210.h create mode 100644 sound/soc/codecs/wm8904.c create mode 100644 sound/soc/codecs/wm8904.h create mode 100644 sound/soc/codecs/wm8955.c create mode 100644 sound/soc/codecs/wm8955.h create mode 100644 sound/soc/sh/fsi-da7210.c
At Tue, 12 Jan 2010 14:27:25 +0100, 私 wrote:
At Tue, 12 Jan 2010 13:20:02 +0000, Mark Brown wrote:
The following changes since your topic/asoc branch are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.34
Since they include (via the 2.6.33 merge) a merge of Linus' tree I've only included the changes that aren't already in your tree or mainline in the summary below, though it looks like the diffstat picked up some extra changes due to the way I tried to do that.
Pulled now. I'm going to check cross-build tests.
I got a build error quickly:
sound/soc/codecs/ad1836.c: In function 'ad1836_soc_resume': sound/soc/codecs/ad1836.c:247: error: 'AD1836_ADC_AUX' undeclared (first use in this function) sound/soc/codecs/ad1836.c:247: error: (Each undeclared identifier is reported only once sound/soc/codecs/ad1836.c:247: error: for each function it appears in.)
This must be one of Barry's patches.
Takashi
At Tue, 12 Jan 2010 14:35:12 +0100, I wrote:
Pulled now. I'm going to check cross-build tests.
I got a build error quickly:
Yet another one.
sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'lm4853_set_spk': sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: 'S3C2440_GPJ2' undeclared (first use in this function) sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: (Each undeclared identifier is reported only once sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: for each function it appears in.) sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'lm4853_event': sound/soc/s3c24xx/neo1973_gta02_wm8753.c:265: error: 'S3C2440_GPJ1' undeclared (first use in this function) sound/soc/s3c24xx/neo1973_gta02_wm8753.c:265: error: 'value' undeclared (first use in this function) sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'neo1973_gta02_init': sound/soc/s3c24xx/neo1973_gta02_wm8753.c:450: error: 'S3C2440_GPJ2' undeclared (first use in this function) sound/soc/s3c24xx/neo1973_gta02_wm8753.c:456: error: 'GTA02_GPIO_AMP_HP_IN' undeclared (first use in this function) sound/soc/s3c24xx/neo1973_gta02_wm8753.c:462: error: 'S3C2440_GPJ1' undeclared (first use in this function) sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'neo1973_gta02_exit': sound/soc/s3c24xx/neo1973_gta02_wm8753.c:490: error: 'S3C2440_GPJ2' undeclared (first use in this function) sound/soc/s3c24xx/neo1973_gta02_wm8753.c:491: error: 'S3C2440_GPJ1' undeclared (first use in this function)
Maybe broken for a long time on the upstream tree?
Takashi
On Tue, Jan 12, 2010 at 02:40:17PM +0100, Takashi Iwai wrote:
I wrote:
I got a build error quickly:
Yet another one.
sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'lm4853_set_spk': sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: 'S3C2440_GPJ2' undeclared (first use in this function) sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: (Each undeclared identifier is reported only once
This is a cross-tree merge issue, the relevant defines are present in the ARM tree. I'm not too worried about this one, you'll need to build for that one specific machine to run into it.
At Tue, 12 Jan 2010 13:42:23 +0000, Mark Brown wrote:
On Tue, Jan 12, 2010 at 02:40:17PM +0100, Takashi Iwai wrote:
I wrote:
I got a build error quickly:
Yet another one.
sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'lm4853_set_spk': sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: 'S3C2440_GPJ2' undeclared (first use in this function) sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: (Each undeclared identifier is reported only once
This is a cross-tree merge issue, the relevant defines are present in the ARM tree. I'm not too worried about this one, you'll need to build for that one specific machine to run into it.
Yeah, so I left as is until now ;)
Takashi
On Tue, Jan 12, 2010 at 02:35:12PM +0100, Takashi Iwai wrote:
I got a build error quickly:
sound/soc/codecs/ad1836.c: In function 'ad1836_soc_resume': sound/soc/codecs/ad1836.c:247: error: 'AD1836_ADC_AUX' undeclared (first use in this function) sound/soc/codecs/ad1836.c:247: error: (Each undeclared identifier is reported only once sound/soc/codecs/ad1836.c:247: error: for each function it appears in.)
This must be one of Barry's patches.
Yes, it's afe1c2cd71eb4e0fade720b5709722e7124f29c0. None of my build test configs appear to manage to cover both SPI and PM at the minute which is why I didn't hit it. This'll do for now, Barry could you please submit a new patch?
The following changes since commit 163849ea9b4c5d50fbd324692461983d18faadad: Mark Brown (1): Merge branch 'for-2.6.33' into for-2.6.34
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.34
Mark Brown (1): Revert "ASoC: ad1836: reset and restore clock control mode in suspend/resume entry"
sound/soc/codecs/ad1836.c | 32 -------------------------------- 1 files changed, 0 insertions(+), 32 deletions(-)
At Tue, 12 Jan 2010 14:08:35 +0000, Mark Brown wrote:
On Tue, Jan 12, 2010 at 02:35:12PM +0100, Takashi Iwai wrote:
I got a build error quickly:
sound/soc/codecs/ad1836.c: In function 'ad1836_soc_resume': sound/soc/codecs/ad1836.c:247: error: 'AD1836_ADC_AUX' undeclared (first use in this function) sound/soc/codecs/ad1836.c:247: error: (Each undeclared identifier is reported only once sound/soc/codecs/ad1836.c:247: error: for each function it appears in.)
This must be one of Barry's patches.
Yes, it's afe1c2cd71eb4e0fade720b5709722e7124f29c0. None of my build test configs appear to manage to cover both SPI and PM at the minute which is why I didn't hit it.
You can get it simply by make allyesconfig with ARM.
Takashi
On Tue, Jan 12, 2010 at 03:14:20PM +0100, Takashi Iwai wrote:
Mark Brown wrote:
Yes, it's afe1c2cd71eb4e0fade720b5709722e7124f29c0. None of my build test configs appear to manage to cover both SPI and PM at the minute which is why I didn't hit it.
You can get it simply by make allyesconfig with ARM.
Yeah, I've added configs in so it should be covered now. I've tended to avoid all*config since I'm using the same test set for everything and it tends to turn up far too many unrelated problems with some of the trees I test regularly.
At Tue, 12 Jan 2010 14:19:23 +0000, Mark Brown wrote:
On Tue, Jan 12, 2010 at 03:14:20PM +0100, Takashi Iwai wrote:
Mark Brown wrote:
Yes, it's afe1c2cd71eb4e0fade720b5709722e7124f29c0. None of my build test configs appear to manage to cover both SPI and PM at the minute which is why I didn't hit it.
You can get it simply by make allyesconfig with ARM.
Yeah, I've added configs in so it should be covered now. I've tended to avoid all*config since I'm using the same test set for everything and it tends to turn up far too many unrelated problems with some of the trees I test regularly.
I also don't give too much attention to spontaneous build errors but the one like this is quite easy to spot out :)
Takashi
On Tue, Jan 12, 2010 at 10:08 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Tue, Jan 12, 2010 at 02:35:12PM +0100, Takashi Iwai wrote:
I got a build error quickly:
sound/soc/codecs/ad1836.c: In function 'ad1836_soc_resume': sound/soc/codecs/ad1836.c:247: error: 'AD1836_ADC_AUX' undeclared (first use in this function) sound/soc/codecs/ad1836.c:247: error: (Each undeclared identifier is reported only once sound/soc/codecs/ad1836.c:247: error: for each function it appears in.)
I am deeply sorry there is a line change in ad1836.h too, but I forgot to include it in the patch.
This must be one of Barry's patches.
Yes, it's afe1c2cd71eb4e0fade720b5709722e7124f29c0. None of my build test configs appear to manage to cover both SPI and PM at the minute which is why I didn't hit it. This'll do for now, Barry could you please submit a new patch?
The following changes since commit 163849ea9b4c5d50fbd324692461983d18faadad: Mark Brown (1): Merge branch 'for-2.6.33' into for-2.6.34
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.34
Mark Brown (1): Revert "ASoC: ad1836: reset and restore clock control mode in suspend/resume entry"
sound/soc/codecs/ad1836.c | 32 -------------------------------- 1 files changed, 0 insertions(+), 32 deletions(-)
At Tue, 12 Jan 2010 14:27:25 +0100, I wrote:
At Tue, 12 Jan 2010 13:20:02 +0000, Mark Brown wrote:
The following changes since your topic/asoc branch are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.34
Since they include (via the 2.6.33 merge) a merge of Linus' tree I've only included the changes that aren't already in your tree or mainline in the summary below, though it looks like the diffstat picked up some extra changes due to the way I tried to do that.
Pulled now. I'm going to check cross-build tests.
Other low-hanging fruits:
sound/soc/codecs/da7210.c:499: warning: 'da7210_i2c_remove' defined but not used sound/soc/codecs/tlv320dac33.c:1349: warning: 'dac33_i2c_remove' defined but not used sound/soc/codecs/tpa6130a2.c:483: warning: 'tpa6130a2_remove' defined but not used
Should be easily fixed by adding __devexit (and better with __devinit) properly.
Takashi
On Tue, Jan 12, 2010 at 02:48:46PM +0100, Takashi Iwai wrote:
Other low-hanging fruits:
sound/soc/codecs/da7210.c:499: warning: 'da7210_i2c_remove' defined but not used sound/soc/codecs/tlv320dac33.c:1349: warning: 'dac33_i2c_remove' defined but not used sound/soc/codecs/tpa6130a2.c:483: warning: 'tpa6130a2_remove' defined but not used
Should be easily fixed by adding __devexit (and better with __devinit) properly.
What config do you use to generate these warnings? None of mine generate them.
On Tuesday 12 January 2010 16:09:37 ext Mark Brown wrote:
On Tue, Jan 12, 2010 at 02:48:46PM +0100, Takashi Iwai wrote:
Other low-hanging fruits:
sound/soc/codecs/da7210.c:499: warning: 'da7210_i2c_remove' defined but not used sound/soc/codecs/tlv320dac33.c:1349: warning: 'dac33_i2c_remove' defined but not used sound/soc/codecs/tpa6130a2.c:483: warning: 'tpa6130a2_remove' defined but not used
Should be easily fixed by adding __devexit (and better with __devinit) properly.
What config do you use to generate these warnings? None of mine generate them.
I have not seen them either, but I will send a patch for the tpa and dac33, and add the __devexit and __devinit to *_probe *_remove.
On Tue, Jan 12, 2010 at 04:12:41PM +0200, Peter Ujfalusi wrote:
On Tuesday 12 January 2010 16:09:37 ext Mark Brown wrote:
What config do you use to generate these warnings? None of mine generate them.
I have not seen them either, but I will send a patch for the tpa and dac33, and add the __devexit and __devinit to *_probe *_remove.
It's OK, I've done that patch already.
On Tuesday 12 January 2010 16:14:48 ext Mark Brown wrote:
On Tue, Jan 12, 2010 at 04:12:41PM +0200, Peter Ujfalusi wrote:
On Tuesday 12 January 2010 16:09:37 ext Mark Brown wrote:
What config do you use to generate these warnings? None of mine generate them.
I have not seen them either, but I will send a patch for the tpa and dac33, and add the __devexit and __devinit to *_probe *_remove.
It's OK, I've done that patch already.
Than I don't send them, thanks.
At Tue, 12 Jan 2010 14:09:37 +0000, Mark Brown wrote:
On Tue, Jan 12, 2010 at 02:48:46PM +0100, Takashi Iwai wrote:
Other low-hanging fruits:
sound/soc/codecs/da7210.c:499: warning: 'da7210_i2c_remove' defined but not used sound/soc/codecs/tlv320dac33.c:1349: warning: 'dac33_i2c_remove' defined but not used sound/soc/codecs/tpa6130a2.c:483: warning: 'tpa6130a2_remove' defined but not used
Should be easily fixed by adding __devexit (and better with __devinit) properly.
What config do you use to generate these warnings? None of mine generate them.
They are from make allyesconfig with certain config files, such as ixp2000_defconfig or footbridge_defconfig. For example,
% cp arch/arm/configs/footbridge_defconfig .config % KCONFIG_ALLCONFIG=.config make ARCH=arm allyesconfig
Takashi
On Tue, Jan 12, 2010 at 03:19:45PM +0100, Takashi Iwai wrote:
They are from make allyesconfig with certain config files, such as ixp2000_defconfig or footbridge_defconfig. For example,
% cp arch/arm/configs/footbridge_defconfig .config % KCONFIG_ALLCONFIG=.config make ARCH=arm allyesconfig
Looks like CONFIG_HOTPLUG not being set is the culprit.
At Tue, 12 Jan 2010 14:37:48 +0000, Mark Brown wrote:
On Tue, Jan 12, 2010 at 03:19:45PM +0100, Takashi Iwai wrote:
They are from make allyesconfig with certain config files, such as ixp2000_defconfig or footbridge_defconfig. For example,
% cp arch/arm/configs/footbridge_defconfig .config % KCONFIG_ALLCONFIG=.config make ARCH=arm allyesconfig
Looks like CONFIG_HOTPLUG not being set is the culprit.
Looks so. The remove path is deactivated only when no hotplug is used (i.e. also no dynamic binding).
That said, the warnings are very subtle and maybe never be any problem in reality.
thanks,
Takashi
On Tue, Jan 12, 2010 at 03:41:32PM +0100, Takashi Iwai wrote:
Mark Brown wrote:
Looks like CONFIG_HOTPLUG not being set is the culprit.
Looks so. The remove path is deactivated only when no hotplug is used (i.e. also no dynamic binding).
Yes, I'd set up non-modular stuff but hadn't noticed the separate option for hotplug support.
That said, the warnings are very subtle and maybe never be any problem in reality.
It's just code bloat so only a problem if you run out of flash/RAM/whatever which probably isn't an issue in realistic configurations for these drivers. Anyway, this appears to cover it:
The following changes since commit 03e7a35c0ef7a462385fb6a301dfc1b287cac6de: Mark Brown (1): Revert "ASoC: ad1836: reset and restore clock control mode in suspend/resume entry"
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.34
Mark Brown (1): ASoC: Add missing __devexit and __devinit annotations
sound/soc/codecs/da7210.c | 6 +++--- sound/soc/codecs/tlv320dac33.c | 6 +++--- sound/soc/codecs/tpa6130a2.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-)
participants (4)
-
Barry Song -
Mark Brown -
Peter Ujfalusi -
Takashi Iwai