[alsa-devel] Multiple DA9055 chips
It seems we have two drivers in mainline for da9055 on I2C. We've got one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c, both registering themselves identically. What's going on here? Is this a combined CODEC and PMIC, has someone decided to release two chips with the same name or is one of the drivers misnamed?
On Mon, 2013-07-01 at 17:48 +0100, Mark Brown wrote:
It seems we have two drivers in mainline for da9055 on I2C. We've got one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c, both registering themselves identically. What's going on here? Is this a combined CODEC and PMIC, has someone decided to release two chips with the same name or is one of the drivers misnamed?
Yes, this is a combined CODEC and PMIC.
On Tue, Jul 02, 2013 at 03:01:53PM +0530, Ashish Chavan wrote:
On Mon, 2013-07-01 at 17:48 +0100, Mark Brown wrote:
It seems we have two drivers in mainline for da9055 on I2C. We've got one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c, both registering themselves identically. What's going on here? Is this a combined CODEC and PMIC, has someone decided to release two chips with the same name or is one of the drivers misnamed?
Yes, this is a combined CODEC and PMIC.
OK, in that case the CODEC driver is just plain broken then. Did anyone actually test this stuff? Please fix.
On Tue, 2013-07-02 at 10:31 +0100, Mark Brown wrote:
On Tue, Jul 02, 2013 at 03:01:53PM +0530, Ashish Chavan wrote:
On Mon, 2013-07-01 at 17:48 +0100, Mark Brown wrote:
It seems we have two drivers in mainline for da9055 on I2C. We've got one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c, both registering themselves identically. What's going on here? Is this a combined CODEC and PMIC, has someone decided to release two chips with the same name or is one of the drivers misnamed?
Yes, this is a combined CODEC and PMIC.
OK, in that case the CODEC driver is just plain broken then. Did anyone actually test this stuff? Please fix.
Yes, I think so. Actually the CODEC driver was merged before PMIC ino main line and was tested at that time. I will check with PMIC team if they did test with CODEC.
I guess the fix should be in PMIC, right?
On Tue, Jul 02, 2013 at 03:32:37PM +0530, Ashish Chavan wrote:
OK, in that case the CODEC driver is just plain broken then. Did anyone actually test this stuff? Please fix.
Yes, I think so. Actually the CODEC driver was merged before PMIC ino main line and was tested at that time. I will check with PMIC team if they did test with CODEC.
I guess the fix should be in PMIC, right?
Both drivers need to be changed.
On Tue, 2013-07-02 at 11:31 +0100, Mark Brown wrote:
On Tue, Jul 02, 2013 at 03:32:37PM +0530, Ashish Chavan wrote:
OK, in that case the CODEC driver is just plain broken then. Did anyone actually test this stuff? Please fix.
Yes, I think so. Actually the CODEC driver was merged before PMIC ino main line and was tested at that time. I will check with PMIC team if they did test with CODEC.
I guess the fix should be in PMIC, right?
Both drivers need to be changed.
OK. We will fix both of them. Thanks for pointing this out.
participants (2)
-
Ashish Chavan -
Mark Brown