[PATCH] ASoC: max98363: set varaiable soc_codec_dev_max98363 storage-class-specifier to static
smatch reports sound/soc/codecs/max98363.c:392:39: warning: symbol 'soc_codec_dev_max98363' was not declared. Should it be static?
This variable is only used in one file so should be static.
Signed-off-by: Tom Rix trix@redhat.com --- sound/soc/codecs/max98363.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/max98363.c b/sound/soc/codecs/max98363.c index 4585ebb1e82c..dcce06bff756 100644 --- a/sound/soc/codecs/max98363.c +++ b/sound/soc/codecs/max98363.c @@ -389,7 +389,7 @@ static const struct snd_soc_dapm_route max98363_audio_map[] = { {"BE_OUT", NULL, "AIFIN"}, };
-const struct snd_soc_component_driver soc_codec_dev_max98363 = { +static const struct snd_soc_component_driver soc_codec_dev_max98363 = { .controls = max98363_snd_controls, .num_controls = ARRAY_SIZE(max98363_snd_controls), .dapm_widgets = max98363_dapm_widgets,
On Thu, 06 Apr 2023 11:23:00 -0400, Tom Rix wrote:
smatch reports sound/soc/codecs/max98363.c:392:39: warning: symbol 'soc_codec_dev_max98363' was not declared. Should it be static?
This variable is only used in one file so should be static.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: max98363: set varaiable soc_codec_dev_max98363 storage-class-specifier to static commit: 80a4623eb1910d099e3d3de1564a6dfe16750e60
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (2)
-
Mark Brown -
Tom Rix