[alsa-devel] [PATCH] fix section mismatch in the sound_core
From: Krzysztof Helt krzysztof.h1@wp.pl
The __exit cleanup_oss_soundcore() is called from the __init init_soundcore(). This causes section mismatch and breaks kernel's linking on sparc64.
Remove the __exit attribute from the cleanup_oss_soundcore().
Signed-off-by: Krzysztof Helt krzysztof.h1@wp.pl --- Patch against 2.6.27-rc5-mm1.
diff -urp linux-ref/sound/sound_core.c linux-2.6.26/sound/sound_core.c --- linux-ref/sound/sound_core.c 2008-09-07 18:54:22.800008536 -0400 +++ linux-2.6.26/sound/sound_core.c 2008-09-07 18:55:56.805521447 -0400 @@ -13,7 +13,7 @@
#ifdef CONFIG_SOUND_OSS_CORE static int __init init_oss_soundcore(void); -static void __exit cleanup_oss_soundcore(void); +static void cleanup_oss_soundcore(void); #else static inline int init_oss_soundcore(void) { return 0; } static inline void cleanup_oss_soundcore(void) { } @@ -573,7 +573,7 @@ int soundcore_open(struct inode *inode,
MODULE_ALIAS_CHARDEV_MAJOR(SOUND_MAJOR);
-static void __exit cleanup_oss_soundcore(void) +static void cleanup_oss_soundcore(void) { /* We have nothing to really do here - we know the lists must be empty */
---------------------------------------------------------------------- Tanie polaczenia z Polska i ze swiatem Sprawdz >> http://link.interia.pl/f1f00
At Sun, 7 Sep 2008 17:24:33 +0200, Krzysztof Helt wrote:
From: Krzysztof Helt krzysztof.h1@wp.pl
The __exit cleanup_oss_soundcore() is called from the __init init_soundcore(). This causes section mismatch and breaks kernel's linking on sparc64.
Remove the __exit attribute from the cleanup_oss_soundcore().
Signed-off-by: Krzysztof Helt krzysztof.h1@wp.pl
Thanks, applied now.
Takashi
Patch against 2.6.27-rc5-mm1.
diff -urp linux-ref/sound/sound_core.c linux-2.6.26/sound/sound_core.c --- linux-ref/sound/sound_core.c 2008-09-07 18:54:22.800008536 -0400 +++ linux-2.6.26/sound/sound_core.c 2008-09-07 18:55:56.805521447 -0400 @@ -13,7 +13,7 @@
#ifdef CONFIG_SOUND_OSS_CORE static int __init init_oss_soundcore(void); -static void __exit cleanup_oss_soundcore(void); +static void cleanup_oss_soundcore(void); #else static inline int init_oss_soundcore(void) { return 0; } static inline void cleanup_oss_soundcore(void) { } @@ -573,7 +573,7 @@ int soundcore_open(struct inode *inode,
MODULE_ALIAS_CHARDEV_MAJOR(SOUND_MAJOR);
-static void __exit cleanup_oss_soundcore(void) +static void cleanup_oss_soundcore(void) { /* We have nothing to really do here - we know the lists must be empty */
Tanie polaczenia z Polska i ze swiatem Sprawdz >> http://link.interia.pl/f1f00
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (2)
-
Krzysztof Helt
-
Takashi Iwai