[alsa-devel] [PATCH] ASoC: rt5640: add default case for unexpected ID
From: Bard Liao bardliao@realtek.com
We may read an unexpected value when detemining which codec is attached. In that case, either a unsupported codec is attached or something wrong with I2C. The driver will not work properly on both cases. So we return an error for that.
Signed-off-by: Bard Liao bardliao@realtek.com --- sound/soc/codecs/rt5640.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c index b0967df..9e0d48f 100644 --- a/sound/soc/codecs/rt5640.c +++ b/sound/soc/codecs/rt5640.c @@ -2019,6 +2019,10 @@ static int rt5640_probe(struct snd_soc_codec *codec) rt5639_specific_dapm_routes, ARRAY_SIZE(rt5639_specific_dapm_routes)); break; + default: + dev_err(codec->dev, + "The driver is for RT5639 RT5640 or RT5642 only\n"); + return -ENODEV; }
return 0;
On 05/06/2014 01:56 AM, bardliao@realtek.com wrote:
From: Bard Liao bardliao@realtek.com
We may read an unexpected value when detemining which codec is attached. In that case, either a unsupported codec is attached or something wrong with I2C. The driver will not work properly on both cases. So we return an error for that.
Reviewed-by: Stephen Warren swarren@nvidia.com
On Tue, May 06, 2014 at 03:56:06PM +0800, bardliao@realtek.com wrote:
From: Bard Liao bardliao@realtek.com
We may read an unexpected value when detemining which codec is attached. In that case, either a unsupported codec is attached or something wrong with I2C. The driver will not work properly on both cases. So we return an error for that.
Applied, thanks.
participants (3)
-
bardliao@realtek.com
-
Mark Brown
-
Stephen Warren