[PATCH 1/2] ASoC: dt-bindings: add pin-switches to audio-graph-card2.yaml
Document support for pin-switches in audio-graph-card2 this devicetree property behaves the same way as its homonym in simple-card
Reviewed-by: Alvin Šipraga alsi@bang-olufsen.dk Signed-off-by: Alvin Šipraga alsi@bang-olufsen.dk Signed-off-by: Claudio Cabral clca@bang-olufsen.dk --- Documentation/devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml index 7416067c945e..ab2cc83d6b4b 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml @@ -32,6 +32,9 @@ properties: codec2codec: type: object description: Codec to Codec node + pin-switches: + description: the widget names for which pin switches must be created. + $ref: /schemas/types.yaml#/definitions/string-array
required: - compatible
Add asoc_simple_parse_pin_switches to audio_graph2_parse_of. This replicates the functionality of simple-audio-card, which allows the creation of ALSA controls to be associated with DAPM nodes through the device tree
Reviewed-by: Alvin Šipraga alsi@bang-olufsen.dk Signed-off-by: Alvin Šipraga alsi@bang-olufsen.dk Signed-off-by: Claudio Cabral clca@bang-olufsen.dk --- sound/soc/generic/audio-graph-card2.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/sound/soc/generic/audio-graph-card2.c b/sound/soc/generic/audio-graph-card2.c index 8ac6df645ee6..aa086a3ebf9c 100644 --- a/sound/soc/generic/audio-graph-card2.c +++ b/sound/soc/generic/audio-graph-card2.c @@ -1245,6 +1245,10 @@ int audio_graph2_parse_of(struct asoc_simple_priv *priv, struct device *dev, if (ret < 0) goto err;
+ ret = asoc_simple_parse_pin_switches(card, NULL); + if (ret < 0) + return ret; + memset(li, 0, sizeof(*li)); ret = graph_for_each_link(priv, hooks, li, graph_link); if (ret < 0)
On 05/10/2022 16:27, Claudio Cabral wrote:
Document support for pin-switches in audio-graph-card2
Full stop?
this devicetree property behaves the same way as its homonym in simple-card
Missing capital letter and full stop?
Instead please describe why do you need pin-switches in this binding...
Reviewed-by: Alvin Šipraga alsi@bang-olufsen.dk Signed-off-by: Alvin Šipraga alsi@bang-olufsen.dk
Authorship or contributions (SoB) usually means someone reviewed it and there is no need for both tags. The combination of both tags above is a bit surprising.
Signed-off-by: Claudio Cabral clca@bang-olufsen.dk
Documentation/devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ 1 file changed, 3 insertions(+)
Best regards, Krzysztof
participants (2)
-
Claudio Cabral -
Krzysztof Kozlowski