[PATCH 1/2] ALSA: emu10k1: clean up driver status comments
Empty BUGS and TODO sections don't really help anyone, so remove them.
Version information is chronically outdated, and not really useful in a git world anyway, so remove it as well.
Also remove duplicated (and outdated, of course) status section from p16v.h (the one in p16v.c is in better shape).
Signed-off-by: Oswald Buddenhagen oswald.buddenhagen@gmx.de --- sound/pci/emu10k1/emu10k1_main.c | 6 ---- sound/pci/emu10k1/emufx.c | 6 ---- sound/pci/emu10k1/emumixer.c | 6 ---- sound/pci/emu10k1/emupcm.c | 6 ---- sound/pci/emu10k1/emuproc.c | 6 ---- sound/pci/emu10k1/io.c | 6 ---- sound/pci/emu10k1/irq.c | 6 ---- sound/pci/emu10k1/p16v.h | 56 -------------------------------- sound/pci/emu10k1/p17v.h | 1 - sound/pci/emu10k1/timer.c | 6 ---- sound/pci/emu10k1/tina2.h | 1 - sound/pci/emu10k1/voice.c | 6 ---- 12 files changed, 112 deletions(-)
diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c index a11fcba4b9af..529d0bba87da 100644 --- a/sound/pci/emu10k1/emu10k1_main.c +++ b/sound/pci/emu10k1/emu10k1_main.c @@ -8,12 +8,6 @@ * Added support for Audigy 2 Value. * Added EMU 1010 support. * General bug fixes and enhancements. - * - * BUGS: - * -- - * - * TODO: - * -- */
#include <linux/sched.h> diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c index 9904bcfee106..e0ad339c5bbf 100644 --- a/sound/pci/emu10k1/emufx.c +++ b/sound/pci/emu10k1/emufx.c @@ -6,12 +6,6 @@ * * Copyright (c) by James Courtier-Dutton James@superbug.co.uk * Added EMU 1010 support. - * - * BUGS: - * -- - * - * TODO: - * -- */
#include <linux/pci.h> diff --git a/sound/pci/emu10k1/emumixer.c b/sound/pci/emu10k1/emumixer.c index 9a94f08f2463..6ff59c44da36 100644 --- a/sound/pci/emu10k1/emumixer.c +++ b/sound/pci/emu10k1/emumixer.c @@ -8,12 +8,6 @@ * * Copyright (c) by James Courtier-Dutton James@superbug.co.uk * Added EMU 1010 support. - * - * BUGS: - * -- - * - * TODO: - * -- */
#include <linux/time.h> diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c index 8b3d1b35d6e7..7a1d448f0656 100644 --- a/sound/pci/emu10k1/emupcm.c +++ b/sound/pci/emu10k1/emupcm.c @@ -4,12 +4,6 @@ * Creative Labs, Inc. * Routines for control of EMU10K1 chips / PCM routines * Multichannel PCM support Copyright (c) Lee Revell rlrevell@joe-job.com - * - * BUGS: - * -- - * - * TODO: - * -- */
#include <linux/pci.h> diff --git a/sound/pci/emu10k1/emuproc.c b/sound/pci/emu10k1/emuproc.c index 5533277e4d47..39b422297c70 100644 --- a/sound/pci/emu10k1/emuproc.c +++ b/sound/pci/emu10k1/emuproc.c @@ -6,12 +6,6 @@ * * Copyright (c) by James Courtier-Dutton James@superbug.co.uk * Added EMU 1010 support. - * - * BUGS: - * -- - * - * TODO: - * -- */
#include <linux/slab.h> diff --git a/sound/pci/emu10k1/io.c b/sound/pci/emu10k1/io.c index c695cb863e5e..7e4483c5bd2a 100644 --- a/sound/pci/emu10k1/io.c +++ b/sound/pci/emu10k1/io.c @@ -3,12 +3,6 @@ * Copyright (c) by Jaroslav Kysela perex@perex.cz * Creative Labs, Inc. * Routines for control of EMU10K1 chips - * - * BUGS: - * -- - * - * TODO: - * -- */
#include <linux/time.h> diff --git a/sound/pci/emu10k1/irq.c b/sound/pci/emu10k1/irq.c index 8573248dd799..71aa90b9cc88 100644 --- a/sound/pci/emu10k1/irq.c +++ b/sound/pci/emu10k1/irq.c @@ -3,12 +3,6 @@ * Copyright (c) by Jaroslav Kysela perex@perex.cz * Creative Labs, Inc. * Routines for IRQ control of EMU10K1 chips - * - * BUGS: - * -- - * - * TODO: - * -- */
#include <linux/time.h> diff --git a/sound/pci/emu10k1/p16v.h b/sound/pci/emu10k1/p16v.h index 9d429ad1feff..95ab8071751b 100644 --- a/sound/pci/emu10k1/p16v.h +++ b/sound/pci/emu10k1/p16v.h @@ -2,62 +2,6 @@ /* * Copyright (c) by James Courtier-Dutton James@superbug.demon.co.uk * Driver p16v chips - * Version: 0.21 - * - * FEATURES currently supported: - * Output fixed at S32_LE, 2 channel to hw:0,0 - * Rates: 44.1, 48, 96, 192. - * - * Changelog: - * 0.8 - * Use separate card based buffer for periods table. - * 0.9 - * Use 2 channel output streams instead of 8 channel. - * (8 channel output streams might be good for ASIO type output) - * Corrected speaker output, so Front -> Front etc. - * 0.10 - * Fixed missed interrupts. - * 0.11 - * Add Sound card model number and names. - * Add Analog volume controls. - * 0.12 - * Corrected playback interrupts. Now interrupt per period, instead of half period. - * 0.13 - * Use single trigger for multichannel. - * 0.14 - * Mic capture now works at fixed: S32_LE, 96000Hz, Stereo. - * 0.15 - * Force buffer_size / period_size == INTEGER. - * 0.16 - * Update p16v.c to work with changed alsa api. - * 0.17 - * Update p16v.c to work with changed alsa api. Removed boot_devs. - * 0.18 - * Merging with snd-emu10k1 driver. - * 0.19 - * One stereo channel at 24bit now works. - * 0.20 - * Added better register defines. - * 0.21 - * Split from p16v.c - * - * BUGS: - * Some stability problems when unloading the snd-p16v kernel module. - * -- - * - * TODO: - * SPDIF out. - * Find out how to change capture sample rates. E.g. To record SPDIF at 48000Hz. - * Currently capture fixed at 48000Hz. - * - * -- - * GENERAL INFO: - * Model: SB0240 - * P16V Chip: CA0151-DBS - * Audigy 2 Chip: CA0102-IAT - * AC97 Codec: STAC 9721 - * ADC: Philips 1361T (Stereo 24bit) - * DAC: CS4382-K (8-channel, 24bit, 192Khz) * * This code was initially based on code from ALSA's emu10k1x.c which is: * Copyright (c) by Francisco Moraes fmoraes@nc.rr.com diff --git a/sound/pci/emu10k1/p17v.h b/sound/pci/emu10k1/p17v.h index d4ada1c430c8..ee4f4ab4b79c 100644 --- a/sound/pci/emu10k1/p17v.h +++ b/sound/pci/emu10k1/p17v.h @@ -2,7 +2,6 @@ /* * Copyright (c) by James Courtier-Dutton James@superbug.demon.co.uk * Driver p17v chips - * Version: 0.01 */
/******************************************************************************/ diff --git a/sound/pci/emu10k1/timer.c b/sound/pci/emu10k1/timer.c index f3c78adf3248..8798604e7f98 100644 --- a/sound/pci/emu10k1/timer.c +++ b/sound/pci/emu10k1/timer.c @@ -3,12 +3,6 @@ * Copyright (c) by Lee Revell rlrevell@joe-job.com * Clemens Ladisch clemens@ladisch.de * Routines for control of EMU10K1 chips - * - * BUGS: - * -- - * - * TODO: - * -- */
#include <linux/time.h> diff --git a/sound/pci/emu10k1/tina2.h b/sound/pci/emu10k1/tina2.h index 7fd235345292..e3fcb290271c 100644 --- a/sound/pci/emu10k1/tina2.h +++ b/sound/pci/emu10k1/tina2.h @@ -2,7 +2,6 @@ /* * Copyright (c) by James Courtier-Dutton James@superbug.demon.co.uk * Driver tina2 chips - * Version: 0.1 */
/********************************************************************************************************/ diff --git a/sound/pci/emu10k1/voice.c b/sound/pci/emu10k1/voice.c index 6939498e26f0..ffe87f359a0e 100644 --- a/sound/pci/emu10k1/voice.c +++ b/sound/pci/emu10k1/voice.c @@ -6,12 +6,6 @@ * Routines for control of EMU10K1 chips - voice manager * * Rewrote voice allocator for multichannel support - rlrevell 12/2004 - * - * BUGS: - * -- - * - * TODO: - * -- */
#include <linux/time.h>
- Remove the "log-like" parts, following the same logic as the previous commit - Unify format - Add missing major contributors, including myself - Sort entries in order of first contribution (Creative comes last for optical reasons; they don't appear to have directly contributed anyway)
Signed-off-by: Oswald Buddenhagen oswald.buddenhagen@gmx.de --- sound/pci/emu10k1/emu10k1.c | 4 +--- sound/pci/emu10k1/emu10k1_main.c | 8 +++----- sound/pci/emu10k1/emufx.c | 6 +++--- sound/pci/emu10k1/emumixer.c | 8 ++++---- sound/pci/emu10k1/emupcm.c | 5 ++++- sound/pci/emu10k1/emuproc.c | 7 ++++--- sound/pci/emu10k1/io.c | 4 ++++ sound/pci/emu10k1/timer.c | 2 ++ sound/pci/emu10k1/voice.c | 6 +++--- 9 files changed, 28 insertions(+), 22 deletions(-)
diff --git a/sound/pci/emu10k1/emu10k1.c b/sound/pci/emu10k1/emu10k1.c index 1a13c086e86c..ba8e5534e2df 100644 --- a/sound/pci/emu10k1/emu10k1.c +++ b/sound/pci/emu10k1/emu10k1.c @@ -2,9 +2,7 @@ /* * The driver for the EMU10K1 (SB Live!) based soundcards * Copyright (c) by Jaroslav Kysela perex@perex.cz - * - * Copyright (c) by James Courtier-Dutton James@superbug.demon.co.uk - * Added support for Audigy 2 Value. + * James Courtier-Dutton James@superbug.co.uk */
#include <linux/init.h> diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c index 529d0bba87da..d3a37d805fb2 100644 --- a/sound/pci/emu10k1/emu10k1_main.c +++ b/sound/pci/emu10k1/emu10k1_main.c @@ -1,13 +1,11 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) by Jaroslav Kysela perex@perex.cz + * James Courtier-Dutton James@superbug.co.uk + * Oswald Buddenhagen oswald.buddenhagen@gmx.de * Creative Labs, Inc. - * Routines for control of EMU10K1 chips * - * Copyright (c) by James Courtier-Dutton James@superbug.co.uk - * Added support for Audigy 2 Value. - * Added EMU 1010 support. - * General bug fixes and enhancements. + * Routines for control of EMU10K1 chips */
#include <linux/sched.h> diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c index e0ad339c5bbf..347141635604 100644 --- a/sound/pci/emu10k1/emufx.c +++ b/sound/pci/emu10k1/emufx.c @@ -1,11 +1,11 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) by Jaroslav Kysela perex@perex.cz + * James Courtier-Dutton James@superbug.co.uk + * Oswald Buddenhagen oswald.buddenhagen@gmx.de * Creative Labs, Inc. - * Routines for effect processor FX8010 * - * Copyright (c) by James Courtier-Dutton James@superbug.co.uk - * Added EMU 1010 support. + * Routines for effect processor FX8010 */
#include <linux/pci.h> diff --git a/sound/pci/emu10k1/emumixer.c b/sound/pci/emu10k1/emumixer.c index 6ff59c44da36..cb2b4e5553e7 100644 --- a/sound/pci/emu10k1/emumixer.c +++ b/sound/pci/emu10k1/emumixer.c @@ -2,12 +2,12 @@ /* * Copyright (c) by Jaroslav Kysela perex@perex.cz, * Takashi Iwai tiwai@suse.de + * Lee Revell rlrevell@joe-job.com + * James Courtier-Dutton James@superbug.co.uk + * Oswald Buddenhagen oswald.buddenhagen@gmx.de * Creative Labs, Inc. - * Routines for control of EMU10K1 chips / mixer routines - * Multichannel PCM support Copyright (c) Lee Revell rlrevell@joe-job.com * - * Copyright (c) by James Courtier-Dutton James@superbug.co.uk - * Added EMU 1010 support. + * Routines for control of EMU10K1 chips / mixer routines */
#include <linux/time.h> diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c index 7a1d448f0656..7f4c1b38d6ec 100644 --- a/sound/pci/emu10k1/emupcm.c +++ b/sound/pci/emu10k1/emupcm.c @@ -1,9 +1,12 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) by Jaroslav Kysela perex@perex.cz + * Lee Revell rlrevell@joe-job.com + * James Courtier-Dutton James@superbug.co.uk + * Oswald Buddenhagen oswald.buddenhagen@gmx.de * Creative Labs, Inc. + * * Routines for control of EMU10K1 chips / PCM routines - * Multichannel PCM support Copyright (c) Lee Revell rlrevell@joe-job.com */
#include <linux/pci.h> diff --git a/sound/pci/emu10k1/emuproc.c b/sound/pci/emu10k1/emuproc.c index 39b422297c70..2f80fd91017c 100644 --- a/sound/pci/emu10k1/emuproc.c +++ b/sound/pci/emu10k1/emuproc.c @@ -1,11 +1,12 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) by Jaroslav Kysela perex@perex.cz + * Lee Revell rlrevell@joe-job.com + * James Courtier-Dutton James@superbug.co.uk + * Oswald Buddenhagen oswald.buddenhagen@gmx.de * Creative Labs, Inc. - * Routines for control of EMU10K1 chips / proc interface routines * - * Copyright (c) by James Courtier-Dutton James@superbug.co.uk - * Added EMU 1010 support. + * Routines for control of EMU10K1 chips / proc interface routines */
#include <linux/slab.h> diff --git a/sound/pci/emu10k1/io.c b/sound/pci/emu10k1/io.c index 7e4483c5bd2a..74df2330015f 100644 --- a/sound/pci/emu10k1/io.c +++ b/sound/pci/emu10k1/io.c @@ -1,7 +1,11 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) by Jaroslav Kysela perex@perex.cz + * Lee Revell rlrevell@joe-job.com + * James Courtier-Dutton James@superbug.co.uk + * Oswald Buddenhagen oswald.buddenhagen@gmx.de * Creative Labs, Inc. + * * Routines for control of EMU10K1 chips */
diff --git a/sound/pci/emu10k1/timer.c b/sound/pci/emu10k1/timer.c index 8798604e7f98..bb2478319361 100644 --- a/sound/pci/emu10k1/timer.c +++ b/sound/pci/emu10k1/timer.c @@ -2,6 +2,8 @@ /* * Copyright (c) by Lee Revell rlrevell@joe-job.com * Clemens Ladisch clemens@ladisch.de + * Oswald Buddenhagen oswald.buddenhagen@gmx.de + * * Routines for control of EMU10K1 chips */
diff --git a/sound/pci/emu10k1/voice.c b/sound/pci/emu10k1/voice.c index ffe87f359a0e..77fb5427aaed 100644 --- a/sound/pci/emu10k1/voice.c +++ b/sound/pci/emu10k1/voice.c @@ -1,11 +1,11 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) by Jaroslav Kysela perex@perex.cz - * Creative Labs, Inc. * Lee Revell rlrevell@joe-job.com - * Routines for control of EMU10K1 chips - voice manager + * Oswald Buddenhagen oswald.buddenhagen@gmx.de + * Creative Labs, Inc. * - * Rewrote voice allocator for multichannel support - rlrevell 12/2004 + * Routines for control of EMU10K1 chips - voice manager */
#include <linux/time.h>
On Sat, 15 Jul 2023 18:08:38 +0200, Oswald Buddenhagen wrote:
Empty BUGS and TODO sections don't really help anyone, so remove them.
Version information is chronically outdated, and not really useful in a git world anyway, so remove it as well.
Also remove duplicated (and outdated, of course) status section from p16v.h (the one in p16v.c is in better shape).
Signed-off-by: Oswald Buddenhagen oswald.buddenhagen@gmx.de
Applied both patches. Thanks.
Takashi
participants (2)
-
Oswald Buddenhagen -
Takashi Iwai