[PATCH] mtd: cs42l43: use modern PM macro helpers
From: Arnd Bergmann arnd@arndb.de
The old SET_SYSTEM_SLEEP_PM_OPS/SET_RUNTIME_PM_OPS macros required enclosing the function definitions in an #ifdef or marking them __maybe_unused:
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~
Use the modern replacements to avoid the warnings without those annotations.
Fixes: ace6d14481386 ("mfd: cs42l43: Add support for cs42l43 core driver") Signed-off-by: Arnd Bergmann arnd@arndb.de --- drivers/mfd/cs42l43.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 37b23e9bae823..7b6d07cbe6fc6 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -1178,8 +1178,8 @@ static int cs42l43_runtime_resume(struct device *dev) }
EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) = { - SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume) - SET_RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL) + SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume) + RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL) };
MODULE_DESCRIPTION("CS42L43 Core Driver");
On 11/09/2023 12:16, Arnd Bergmann wrote:
From: Arnd Bergmann arnd@arndb.de
The old SET_SYSTEM_SLEEP_PM_OPS/SET_RUNTIME_PM_OPS macros required enclosing the function definitions in an #ifdef or marking them __maybe_unused:
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev)
Commit title has typo. mtd should be mfd.
On 11/09/2023 12:16, Arnd Bergmann wrote:
From: Arnd Bergmann arnd@arndb.de
The old SET_SYSTEM_SLEEP_PM_OPS/SET_RUNTIME_PM_OPS macros required enclosing the function definitions in an #ifdef or marking them __maybe_unused:
<SNIP>
EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) = {
- SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
- SET_RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
- SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
- RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL) };
Charles already sent a patch for this. We're waiting for Lee to merge it. https://lore.kernel.org/all/20230822114914.340359-1-ckeepax@opensource.cirru...
participants (2)
-
Arnd Bergmann
-
Richard Fitzgerald