Re: [alsa-devel] [PATCH] ALSA: firewire: Neaten cmp_error function

20 Oct
2011
20 Oct
'11
9:36 a.m.
Joe Perches wrote:
Use an actual struct va_format instead of casting an array of pointers.
- dev_err(&c->resources.unit->device, "%cPCR%u: %pV",
'i', c->pcr_index, &(struct va_format){ fmt, &va });
There is no cast. This compound literal _is_ an actual struct va_format.
Move a constant char argument to the format string.
Good catch, but this module is going to be extended to handle oPCRs, too.
Regards, Clemens
4938
Age (days ago)
4938
Last active (days ago)
0 comments
1 participants
participants (1)
-
Clemens Ladisch