Re: [alsa-devel] [PATCH] ASoC: supply and micbiases shoud bring "up to" STANDBY
25 Oct
2012
25 Oct
'12
6:49 p.m.
On Wed, Oct 24, 2012 at 02:19:35PM -0700, Shaoming Feng wrote:
/* Supplies and micbiases only bring the
- context up to STANDBY as unless something
- else is active and passing audio they
- generally don't require full power. Signal
- generators are virtual pins and have no
- power impact themselves.
*/
According to the comment, the target bias level shouldn't be higher than STANDBY.
case snd_soc_dapm_clock_supply: case snd_soc_dapm_micbias:
if (d->target_bias_level < SND_SOC_BIAS_STANDBY)
if (d->target_bias_level > SND_SOC_BIAS_STANDBY) d->target_bias_level = SND_SOC_BIAS_STANDBY;
This will do the wrong thing - it'll mean that if we've already found that we need a bias level over _STANDBY we'll pull back to only selecting _STANDBY. The intention here is that we should raise to _STANDBY but this shouldn't distrupt operation of other widgets.
4441
Age (days ago)
4441
Last active (days ago)
0 comments
1 participants
participants (1)
-
Mark Brown