[alsa-devel] [PATCH] ASoC: Relax restrictions on WM8962 BCLK configuration
The restrictions on configuring BCLK are overly cautious, other constraints in the system should ensure that reconfiguration is not possible when the device is sufficiently active to be unable to support reclocking.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com --- sound/soc/codecs/wm8962.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index be34146..38cbf85 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -911,12 +911,6 @@ static void wm8962_configure_bclk(struct snd_soc_codec *codec) int clocking2 = 0; int aif2 = 0;
- /* If the CODEC is powered on we can configure BCLK */ - if (codec->bias_level != SND_SOC_BIAS_OFF) { - dev_dbg(codec->dev, "Bias is off, can't configure BCLK\n"); - return; - } - if (!wm8962->bclk) { dev_dbg(codec->dev, "No BCLK rate configured\n"); return;
On Thu, 2010-09-30 at 14:26 -0700, Mark Brown wrote:
The restrictions on configuring BCLK are overly cautious, other constraints in the system should ensure that reconfiguration is not possible when the device is sufficiently active to be unable to support reclocking.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
sound/soc/codecs/wm8962.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index be34146..38cbf85 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -911,12 +911,6 @@ static void wm8962_configure_bclk(struct snd_soc_codec *codec) int clocking2 = 0; int aif2 = 0;
- /* If the CODEC is powered on we can configure BCLK */
- if (codec->bias_level != SND_SOC_BIAS_OFF) {
dev_dbg(codec->dev, "Bias is off, can't configure BCLK\n");
return;
- }
- if (!wm8962->bclk) { dev_dbg(codec->dev, "No BCLK rate configured\n"); return;
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
On Thu, 2010-09-30 at 14:26 -0700, Mark Brown wrote:
The restrictions on configuring BCLK are overly cautious, other constraints in the system should ensure that reconfiguration is not possible when the device is sufficiently active to be unable to support reclocking.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
participants (2)
-
Liam Girdwood
-
Mark Brown