[alsa-devel] [PATCH] ASoC: tegra: Remove redundant initialisation of compat_filter_fn
From: Mark Brown broonie@linaro.org
Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).
Signed-off-by: Mark Brown broonie@linaro.org --- sound/soc/tegra/tegra_pcm.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/tegra/tegra_pcm.c b/sound/soc/tegra/tegra_pcm.c index f056f63..7b2d23b 100644 --- a/sound/soc/tegra/tegra_pcm.c +++ b/sound/soc/tegra/tegra_pcm.c @@ -56,7 +56,6 @@ static const struct snd_pcm_hardware tegra_pcm_hardware = { static const struct snd_dmaengine_pcm_config tegra_dmaengine_pcm_config = { .pcm_hardware = &tegra_pcm_hardware, .prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config, - .compat_filter_fn = NULL, .prealloc_buffer_size = PAGE_SIZE * 8, };
On 10/19/2013 03:17 PM, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).
The idea was to make it explicit that tegra uses the compat path, but with the filter function set to NULL.
- Lars
On 10/19/2013 02:17 PM, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).
I'm fine with this either way, so feel free to take my ack whichever way you work this out with Lars-Peter.
Acked-by: Stephen Warren swarren@nvidia.com
On 10/20/2013 11:38 PM, Stephen Warren wrote:
On 10/19/2013 02:17 PM, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).
I'm fine with this either way, so feel free to take my ack whichever way you work this out with Lars-Peter.
I don't care that much either, just wanted to give an explanation why things are the way they are. Mark, if you want to merge this patch you can add: Acked-by: Lars-Peter Clausen lars@metafoo.de
Btw. wasn't there a plan to move tegra to the generic dma bindings? If not I think it might be a good idea to add the possibility to let the DMA driver overwrite the DT attribute parsing done by of_dma_match_channel(). This would spare drivers from having to do the parsing manually and it would allow the tegra pcm driver to just follow the normal OF path in the generic-dmaengine-pcm driver and didn't had to rely on the compat path.
- Lars
On 10/22/2013 12:40 PM, Lars-Peter Clausen wrote:
On 10/20/2013 11:38 PM, Stephen Warren wrote:
On 10/19/2013 02:17 PM, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).
I'm fine with this either way, so feel free to take my ack whichever way you work this out with Lars-Peter.
I don't care that much either, just wanted to give an explanation why things are the way they are. Mark, if you want to merge this patch you can add: Acked-by: Lars-Peter Clausen lars@metafoo.de
Btw. wasn't there a plan to move tegra to the generic dma bindings?
IIRC, it's been using them for a release or two.
participants (3)
-
Lars-Peter Clausen -
Mark Brown -
Stephen Warren