Re: [PATCH] ASoC: sunxi: sun4i-codec: fill ASoC card owner
On Wed, Mar 31, 2021 at 04:59:15PM +0200, bage@linutronix.de wrote:
From: Bastian Germann bage@linutronix.de
card->owner is a required property and since commit 81033c6b584b ("ALSA: core: Warn on empty module") a warning is issued if it is empty. Add it. This fixes following warning observed on Lamobo R1:
WARNING: CPU: 1 PID: 190 at sound/core/init.c:207 snd_card_new+0x430/0x480 [snd] Modules linked in: sun4i_codec(E+) sun4i_backend(E+) snd_soc_core(E) ... CPU: 1 PID: 190 Comm: systemd-udevd Tainted: G C E 5.10.0-1-armmp #1 Debian 5.10.4-1 Hardware name: Allwinner sun7i (A20) Family [<c0ce8544>] (dump_backtrace) from [<c0ce88f0>] (show_stack+0x20/0x24) [<c0ce88d0>] (show_stack) from [<c0ceda20>] (dump_stack+0xc8/0xdc) [<c0ced958>] (dump_stack) from [<c034d49c>] (__warn+0xfc/0x158) [<c034d3a0>] (__warn) from [<c0ce966c>] (warn_slowpath_fmt+0x70/0xe4)
Please think hard before including complete backtraces in upstream reports, they are very large and contain almost no useful information relative to their size so often obscure the relevant content in your message. If part of the backtrace is usefully illustrative (it often is for search engines if nothing else) then it's usually better to pull out the relevant sections.
participants (1)
-
Mark Brown