[alsa-devel] [PATCH] sound: Fix empty menuconfig SND_ARM
commit 3c8f7710c1c4 ("ASoC: fix broken pxa SoC support") has removed the SND_ARM dependency from SND_PXA2XX_LIB and SND_PXA2XX_LIB_AC97, by moving these config entries outside of the "if SND_ARM ... endif" construct.
However, by placing these 2 symbols right between the SND_ARM menuconfig definition and the first SND_ARM menu entry, the side effect is that the SND_ARM menu becomes empty and all the config entries caught between "if SND_ARM ... endif" no more belong to menuconfig SND_ARM, but to its parent (menuconfig SND).
Fix this.
Signed-off-by: Eugeniu Rosca rosca.eugeniu@gmail.com --- sound/arm/Kconfig | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/sound/arm/Kconfig b/sound/arm/Kconfig index e040621..65171f6 100644 --- a/sound/arm/Kconfig +++ b/sound/arm/Kconfig @@ -9,14 +9,6 @@ menuconfig SND_ARM Drivers that are implemented on ASoC can be found in "ALSA for SoC audio support" section.
-config SND_PXA2XX_LIB - tristate - select SND_AC97_CODEC if SND_PXA2XX_LIB_AC97 - select SND_DMAENGINE_PCM - -config SND_PXA2XX_LIB_AC97 - bool - if SND_ARM
config SND_ARMAACI @@ -42,3 +34,10 @@ config SND_PXA2XX_AC97
endif # SND_ARM
+config SND_PXA2XX_LIB + tristate + select SND_AC97_CODEC if SND_PXA2XX_LIB_AC97 + select SND_DMAENGINE_PCM + +config SND_PXA2XX_LIB_AC97 + bool
Eugeniu Rosca roscaeugeniu@gmail.com writes:
commit 3c8f7710c1c4 ("ASoC: fix broken pxa SoC support") has removed the SND_ARM dependency from SND_PXA2XX_LIB and SND_PXA2XX_LIB_AC97, by moving these config entries outside of the "if SND_ARM ... endif" construct.
However, by placing these 2 symbols right between the SND_ARM menuconfig definition and the first SND_ARM menu entry, the side effect is that the SND_ARM menu becomes empty and all the config entries caught between "if SND_ARM ... endif" no more belong to menuconfig SND_ARM, but to its parent (menuconfig SND).
Fix this.
NAK.
The reason is that SND_PXA2XX_LIB is used outside of SND_ARM, see sound/soc/pxa/Kconfig, SND_PXA2XX_SOC and co.
With you commit you're breaking every board relying on SND_PXA2XX_SOC but not SND_ARM.
Cheers.
-- Robert
On Sat, Jul 30, 2016 at 04:14:24PM +0200, Robert Jarzmik wrote:
Eugeniu Rosca roscaeugeniu@gmail.com writes:
commit 3c8f7710c1c4 ("ASoC: fix broken pxa SoC support") has removed the SND_ARM dependency from SND_PXA2XX_LIB and SND_PXA2XX_LIB_AC97, by moving these config entries outside of the "if SND_ARM ... endif" construct.
However, by placing these 2 symbols right between the SND_ARM menuconfig definition and the first SND_ARM menu entry, the side effect is that the SND_ARM menu becomes empty and all the config entries caught between "if SND_ARM ... endif" no more belong to menuconfig SND_ARM, but to its parent (menuconfig SND).
Fix this.
NAK.
The reason is that SND_PXA2XX_LIB is used outside of SND_ARM, see sound/soc/pxa/Kconfig, SND_PXA2XX_SOC and co.
With you commit you're breaking every board relying on SND_PXA2XX_SOC but not SND_ARM.
Cheers.
-- Robert
Hi Robert and thanks for the quick reply!
In my understanding, the patch doesn't bring any changes in the relationship between different config options. It only corrects the way the config entries are exposed to the user via "make menuconfig" interface.
Here are two situations that I hope can explain it:
1. Proper (non-empty) menu:
menuconfig A prompt "menu-A"
if A config B prompt "config-B" endif
config C prompt "config-C"
2. Empty menu:
menuconfig A prompt "menu-A"
config C prompt "config-C"
if A config B prompt "config-B" endif
In both cases, the relationship between A, B, C is the same. However, the options are exposed differently by "make menuconfig". Assuming B is enabled:
(1): menu-A config-B config-C
(2): menu-A config-C config-B
In case of (1), B is a child of A (expected) In case of (2), B is a sibling of A (not quite expected)
Let me know if there are still doubts on your side and/or if I can be of any further help.
Thanks, Eugeniu.
Eugeniu Rosca roscaeugeniu@gmail.com writes:
On Sat, Jul 30, 2016 at 04:14:24PM +0200, Robert Jarzmik wrote:
Eugeniu Rosca roscaeugeniu@gmail.com writes:
commit 3c8f7710c1c4 ("ASoC: fix broken pxa SoC support") has removed the SND_ARM dependency from SND_PXA2XX_LIB and SND_PXA2XX_LIB_AC97, by moving these config entries outside of the "if SND_ARM ... endif" construct.
However, by placing these 2 symbols right between the SND_ARM menuconfig definition and the first SND_ARM menu entry, the side effect is that the SND_ARM menu becomes empty and all the config entries caught between "if SND_ARM ... endif" no more belong to menuconfig SND_ARM, but to its parent (menuconfig SND).
Fix this.
NAK.
The reason is that SND_PXA2XX_LIB is used outside of SND_ARM, see sound/soc/pxa/Kconfig, SND_PXA2XX_SOC and co.
With you commit you're breaking every board relying on SND_PXA2XX_SOC but not SND_ARM.
Cheers.
-- Robert
Hi Robert and thanks for the quick reply!
Hi Eugeniu,
Thanks for the explanation, it's very clear.
Moreover I reread your patch, and tested it, and you're actually putting the SND_PXA2XX_LIB and SND_PXA2XX_LIB_AC97 _after_ the endif, while I was reading you put them in the middle of "if ARM ... endif", hence my initial complaint.
Therefore, I remove my NAK, and : Acked-by: Robert Jarzmik robert.jarzmik@free.fr
Cheers.
-- Robert
On Sun, 31 Jul 2016 11:05:07 +0200, Robert Jarzmik wrote:
Eugeniu Rosca roscaeugeniu@gmail.com writes:
On Sat, Jul 30, 2016 at 04:14:24PM +0200, Robert Jarzmik wrote:
Eugeniu Rosca roscaeugeniu@gmail.com writes:
commit 3c8f7710c1c4 ("ASoC: fix broken pxa SoC support") has removed the SND_ARM dependency from SND_PXA2XX_LIB and SND_PXA2XX_LIB_AC97, by moving these config entries outside of the "if SND_ARM ... endif" construct.
However, by placing these 2 symbols right between the SND_ARM menuconfig definition and the first SND_ARM menu entry, the side effect is that the SND_ARM menu becomes empty and all the config entries caught between "if SND_ARM ... endif" no more belong to menuconfig SND_ARM, but to its parent (menuconfig SND).
Fix this.
NAK.
The reason is that SND_PXA2XX_LIB is used outside of SND_ARM, see sound/soc/pxa/Kconfig, SND_PXA2XX_SOC and co.
With you commit you're breaking every board relying on SND_PXA2XX_SOC but not SND_ARM.
Cheers.
-- Robert
Hi Robert and thanks for the quick reply!
Hi Eugeniu,
Thanks for the explanation, it's very clear.
Moreover I reread your patch, and tested it, and you're actually putting the SND_PXA2XX_LIB and SND_PXA2XX_LIB_AC97 _after_ the endif, while I was reading you put them in the middle of "if ARM ... endif", hence my initial complaint.
Therefore, I remove my NAK, and : Acked-by: Robert Jarzmik robert.jarzmik@free.fr
OK, thanks, I applied this one now.
Although it looks like a silly workaround, the real problem is rather the syntax of menuconfig, which ambiguously defines the suboptions, so this seems to be a reasonable fix at the right moment.
Takashi
Thanks Robert, Takashi.
On Mon, Aug 01, 2016 at 04:11:38PM +0200, Takashi Iwai wrote:
[..] the real problem is rather the syntax of menuconfig, which ambiguously defines the suboptions [..]
Proposed some kconfig-language improvement below: http://www.spinics.net/lists/linux-kbuild/msg13171.html
Regards, Eugeniu.
participants (3)
-
Eugeniu Rosca -
Robert Jarzmik -
Takashi Iwai