On Thu, Jan 31, 2013 at 03:02:21AM +0000, Zhang Quan-B13634 wrote:

...

...

• if (!codec_dai->active)

• clk_enable(data->codec_clk);
  

...

Should be clk_prepare_enable() but it's not clear to me why you need this... Also the clock API does refcounting so there should be no need to check for active, you should get matching startups and shutdowns.

This will also fail for analogue bypass paths, set_bias_level() would be a good place to cover those.

[Gary-b13634] for power saving consideration. For now remove this feature to Implement a basic feature

I get why you're doing this at all but doing it in startup seems odd - like I say set_bias_level() is the most idiomatic place to implement this usually. There's a few machine drivers doing that you should be able to refer to for examples.