[PATCH] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev_err()
The print function dev_err() is redundant because platform_get_irq() already prints an error.
Eliminate the follow coccicheck warning: ./sound/soc/atmel/mchp-pdmc.c:991:2-9: line 991 is redundant because platform_get_irq() already prints an error.
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Jiapeng Chong jiapeng.chong@linux.alibaba.com --- sound/soc/atmel/mchp-pdmc.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c index c44636f6207d..2b48bd3434c7 100644 --- a/sound/soc/atmel/mchp-pdmc.c +++ b/sound/soc/atmel/mchp-pdmc.c @@ -988,7 +988,6 @@ static int mchp_pdmc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(dev, "failed to get irq: %d\n", irq); return irq; }
On 10.03.2022 02:22, Jiapeng Chong wrote:
diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c index c44636f6207d..2b48bd3434c7 100644 --- a/sound/soc/atmel/mchp-pdmc.c +++ b/sound/soc/atmel/mchp-pdmc.c @@ -988,7 +988,6 @@ static int mchp_pdmc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0); if (irq < 0) {
dev_err(dev, "failed to get irq: %d\n", irq); return irq; }
The braces should also be removed. With that addressed, you can add:
Reviewed-by: Codrin Ciubotariu codrin.ciubotariu@microchip.com
Thanks!
participants (2)
-
Codrin.Ciubotariu@microchip.com
-
Jiapeng Chong