[alsa-devel] [PATCH v3 0/2] ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.
Inside DSDT table there is record for this soundcard:
Device (RTKC) { Name (_ADR, Zero) // _ADR: Address Name (_HID, "10EC3276") // _HID: Hardware ID Name (_CID, "10EC3276") // _CID: Compatible ID Name (_DDN, "ALC3276") // _DDN: DOS Device Name Name (_SUB, "103C827C") // _SUB: Subsystem ID Name (_PR0, Package (0x01) // _PR0: Power Resources for D0
original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621
v3: Fixed patch descriptions v2: Splited patch to codec and sst parts
Alexandrov Stansilav (2): ASoc: rt5640: Add "10EC3276" ACPI ID ASoC: Intel: Atom: Add HP Pavilion x2 10 10-p000 machine entry
sound/soc/codecs/rt5640.c | 1 + sound/soc/intel/atom/sst/sst_acpi.c | 2 ++ 2 files changed, 3 insertions(+)
Add ACPI ID "10EC3276" for sound card found on notebook HP Pavilion X2 10-p000. ACPI DSDT Table on this device describes this card as ALC3276, but it is in fact rt5640.
Signed-off-by: Alexandrov Stansilav neko@nya.ai --- sound/soc/codecs/rt5640.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c index e29a6de..b857a71 100644 --- a/sound/soc/codecs/rt5640.c +++ b/sound/soc/codecs/rt5640.c @@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match); #ifdef CONFIG_ACPI static const struct acpi_device_id rt5640_acpi_match[] = { { "INT33CA", 0 }, + { "10EC3276", 0 }, { "10EC5640", 0 }, { "10EC5642", 0 }, { "INTCCFFD", 0 },
Add machine entry for HP X2 Pavilion 10-p100. This notebook contains rt5640 codec, but with ACPI ID "10EC3276".
Signed-off-by: Alexandrov Stansilav neko@nya.ai --- sound/soc/intel/atom/sst/sst_acpi.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c index f4d92bb..896ced2 100644 --- a/sound/soc/intel/atom/sst/sst_acpi.c +++ b/sound/soc/intel/atom/sst/sst_acpi.c @@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = { /* some CHT-T platforms rely on RT5640, use Baytrail machine driver */ {"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", cht_quirk, &chv_platform_data }, + {"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL, + &chv_platform_data },
{}, };
On Fri, Jan 06, 2017 at 03:09:45AM +0300, Alexandrov Stansilav wrote:
Inside DSDT table there is record for this soundcard:
Device (RTKC) { Name (_ADR, Zero) // _ADR: Address Name (_HID, "10EC3276") // _HID: Hardware ID Name (_CID, "10EC3276") // _CID: Compatible ID Name (_DDN, "ALC3276") // _DDN: DOS Device Name Name (_SUB, "103C827C") // _SUB: Subsystem ID Name (_PR0, Package (0x01) // _PR0: Power Resources for D0original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621
Looks good to me, both:
Acked-by: Vinod Koul vinod.koul@intel.com
v3: Fixed patch descriptions v2: Splited patch to codec and sst parts
Alexandrov Stansilav (2): ASoc: rt5640: Add "10EC3276" ACPI ID ASoC: Intel: Atom: Add HP Pavilion x2 10 10-p000 machine entry
sound/soc/codecs/rt5640.c | 1 + sound/soc/intel/atom/sst/sst_acpi.c | 2 ++ 2 files changed, 3 insertions(+)
-- 2.10.2
On 01/06/2017 01:07 AM, Vinod Koul wrote:
On Fri, Jan 06, 2017 at 03:09:45AM +0300, Alexandrov Stansilav wrote:
Inside DSDT table there is record for this soundcard:
Device (RTKC) { Name (_ADR, Zero) // _ADR: Address Name (_HID, "10EC3276") // _HID: Hardware ID Name (_CID, "10EC3276") // _CID: Compatible ID Name (_DDN, "ALC3276") // _DDN: DOS Device Name Name (_SUB, "103C827C") // _SUB: Subsystem ID Name (_PR0, Package (0x01) // _PR0: Power Resources for D0original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621
Looks good to me, both:
Acked-by: Vinod Koul vinod.koul@intel.com
Mark was not CC:ed, not sure if he saw these two patches? I have another patch to fix Bugzilla 156191 and add cht+rt5651 in the machine driver list, this will conflict if this set is not merged first. Thanks!
v3: Fixed patch descriptions v2: Splited patch to codec and sst parts
Alexandrov Stansilav (2): ASoc: rt5640: Add "10EC3276" ACPI ID ASoC: Intel: Atom: Add HP Pavilion x2 10 10-p000 machine entry
sound/soc/codecs/rt5640.c | 1 + sound/soc/intel/atom/sst/sst_acpi.c | 2 ++ 2 files changed, 3 insertions(+)
-- 2.10.2
On Fri, Jan 13, 2017 at 02:48:42PM -0600, Pierre-Louis Bossart wrote:
Mark was not CC:ed, not sure if he saw these two patches?
Not if they weren't sent to me.
participants (4)
-
Alexandrov Stansilav -
Mark Brown -
Pierre-Louis Bossart -
Vinod Koul