[PATCH v1 0/6] ASoC: Fix gpiolib dependencies
This series removes a bunch of spurious selects of gpiolib that were causing noise in randconfig build tests.
Mark Brown (6): ASoC: dmic: Remove spurious gpiolib select ASoC: rt9120: Remove spurious gpiolib select ASoC: simple-amplifier: Remove spurious gpiolib select ASoC: max9759: Remove spurious gpiolib select ASoC: zl38060: Remove spurious gpiolib select ASoC: simple-mux: Depend on gpiolib rather than selecting it
sound/soc/codecs/Kconfig | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
base-commit: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07
The usage of GPIOs is optional in the code so don't force on gpiolib when building it, avoiding warnings in randconfigs.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/Kconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index d3e5ae8310ef..18159d560c74 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -842,7 +842,6 @@ config SND_SOC_DA9055
config SND_SOC_DMIC tristate "Generic Digital Microphone CODEC" - depends on GPIOLIB help Enable support for the Generic Digital Microphone CODEC. Select this if your sound card has DMICs.
The usage of GPIOs is optional in the code so don't force on gpiolib when building it, avoiding warnings in randconfigs.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/Kconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 18159d560c74..196b5d9b08c3 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1348,7 +1348,6 @@ config SND_SOC_RT9120 tristate "Richtek RT9120 Stereo Class-D Amplifier" depends on I2C select REGMAP_I2C - select GPIOLIB help Enable support for Richtek RT9120 20W, stereo, inductor-less, high-efficiency Class-D audio amplifier.
The usage of GPIOs is optional in the code so don't force on gpiolib when building it, avoiding warnings in randconfigs.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/Kconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 196b5d9b08c3..54eb6005f99c 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1391,7 +1391,6 @@ config SND_SOC_SIGMADSP_REGMAP
config SND_SOC_SIMPLE_AMPLIFIER tristate "Simple Audio Amplifier" - select GPIOLIB
config SND_SOC_SIMPLE_MUX tristate "Simple Audio Mux"
The usage of GPIOs is optional in the code so don't force on gpiolib when building it, avoiding warnings in randconfigs.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 54eb6005f99c..cee4330fce93 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1912,7 +1912,7 @@ config SND_SOC_LM4857
config SND_SOC_MAX9759 tristate "Maxim MAX9759 speaker Amplifier" - select GPIOLIB + depends on GPIOLIB
config SND_SOC_MAX9768 tristate
The usage of GPIOs is optional in the code so don't force on gpiolib when building it, avoiding warnings in randconfigs.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/Kconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index cee4330fce93..8a2e1c61f616 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1898,7 +1898,6 @@ config SND_SOC_WSA881X config SND_SOC_ZL38060 tristate "Microsemi ZL38060 Connected Home Audio Processor" depends on SPI_MASTER - select GPIOLIB select REGMAP help Support for ZL38060 Connected Home Audio Processor from Microsemi,
The simple-mux driver requires gpiolib. Currently it selects GPIOLIB but since the use of select can lead to issues with randconfig let's instead depend on GPIOLIB, select is more idiomatically used for Kconfig symbols that are not user selectable but GPIOLIB is user selectable.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 8a2e1c61f616..0ef2cfe40723 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1394,7 +1394,7 @@ config SND_SOC_SIMPLE_AMPLIFIER
config SND_SOC_SIMPLE_MUX tristate "Simple Audio Mux" - select GPIOLIB + depends on GPIOLIB
config SND_SOC_SPDIF tristate "S/PDIF CODEC"
On Wed, 2 Feb 2022 19:23:27 +0000, Mark Brown wrote:
This series removes a bunch of spurious selects of gpiolib that were causing noise in randconfig build tests.
Mark Brown (6): ASoC: dmic: Remove spurious gpiolib select ASoC: rt9120: Remove spurious gpiolib select ASoC: simple-amplifier: Remove spurious gpiolib select ASoC: max9759: Remove spurious gpiolib select ASoC: zl38060: Remove spurious gpiolib select ASoC: simple-mux: Depend on gpiolib rather than selecting it
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/6] ASoC: dmic: Remove spurious gpiolib select commit: 823868f59ff4f1a8889120bc71a216542b79d909 [2/6] ASoC: rt9120: Remove spurious gpiolib select commit: 2cc12ef489a39d22230d4029c9890d27902a855b [3/6] ASoC: simple-amplifier: Remove spurious gpiolib select commit: 44bd27c42a1c9a00f1fbcb58301a7f3e6f5cdd0f [4/6] ASoC: max9759: Remove spurious gpiolib select commit: c29744876071c3186871515b3f849a884dc47241 [5/6] ASoC: zl38060: Remove spurious gpiolib select commit: 8e70aaae32b72d3088d18a3447b67112b3f5979a [6/6] ASoC: simple-mux: Depend on gpiolib rather than selecting it commit: 805fff750107bce59f769a54f77205a8c4c37705
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (1)
-
Mark Brown