On Mi, 2018-01-10 at 14:26 +0000, Fischer, Christian wrote:

Hello Fabio,

is it now ok? I'm not working with linux-git, so my patch is created by myself.

Regards, Christian

Signed-off-by: Christian Fischer fischerc@swissphone.de

Hi Christian,

This doesn't look good to me. How are creating/sending the patches?

You should update the commit message to include your Signed-off-by tag and then resend the entire patch.

thanks, Daniel.

--- sound/soc/codecs/sgtl5000.c +++ sound/soc/codecs/sgtl5000.c @@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget     SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event),   SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event),

• SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event),
• SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event),

};    /* routes for sgtl5000 */

-----Ursprüngliche Nachricht----- Von: Fabio Estevam [mailto:festevam@gmail.com]  Gesendet: Mittwoch, 10. Januar 2018 13:42 An: Fischer, Christian fischerc@swissphone.de Cc: alsa-devel@alsa-project.org; Takashi Iwai tiwai@suse.com; Mark Brown broonie@kernel.org; Liam Girdwood lgirdwood@gmail.com Betreff: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Fix powerup/down of micbias

Hi Christian,

On Wed, Jan 10, 2018 at 8:07 AM, Fischer, Christian fischerc@swissphone.de wrote:

...

The bias-bias-voltage should powered up/down automatically. Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function.

Thanks for submitting the patch.

You missed your Signed-off-by tag.

Please resend it.

Thanks _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmailman.al... %7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636511912029282885&sdata=Zo42ZJxIxp54YyYLVsFrrRWkDt%2FqByR6uqr8U6pX3iY%3D&reserved=0