[alsa-devel] [PATCH] Added support to HDAIntel driver for the Foxconn P35AX-S mainboard
Without forcing model type to 6stack-dig, the user gets no sound.
Patch is attached, and alsa-info.sh output is at http://pastebin.ca/1023781.
Changelog: Added IDs for the Foxconn P35AX-S mainboard to patch_realtek.c, so that ALC883_6ST_DIG is used by default.
Signed-off-by: Travis Place <wishie at wishie dot net>
Also, on a side note, are we to use the GIT repo from now on ? I just tried to pull from it, and got an error. HG seems to be working for me still though.
Thanks, Travis Place.
At Wed, 21 May 2008 00:12:02 +1000, Travis Place wrote:
Without forcing model type to 6stack-dig, the user gets no sound.
Patch is attached, and alsa-info.sh output is at http://pastebin.ca/1023781.
Changelog: Added IDs for the Foxconn P35AX-S mainboard to patch_realtek.c, so that ALC883_6ST_DIG is used by default.
Signed-off-by: Travis Place <wishie at wishie dot net>
It's also in the upstream, too.
thanks,
Takashi
On Mon, 26 May 2008 9:04:03 pm Takashi Iwai wrote:
At Wed, 21 May 2008 00:12:02 +1000,
Travis Place wrote:
Without forcing model type to 6stack-dig, the user gets no sound.
Patch is attached, and alsa-info.sh output is at http://pastebin.ca/1023781.
Changelog: Added IDs for the Foxconn P35AX-S mainboard to patch_realtek.c, so that ALC883_6ST_DIG is used by default.
Signed-off-by: Travis Place <wishie at wishie dot net>
It's also in the upstream, too.
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Sorry for the 3 seperate posts Takashi..
Is it ok for me to unify the patches (in the future) and send 1 unified changelog ? Or is it preferred that the patches(and thei changelogs) are seperate ?
Thanks, Travis Place
At Mon, 26 May 2008 23:33:18 +1000, Travis Place wrote:
On Mon, 26 May 2008 9:04:03 pm Takashi Iwai wrote:
At Wed, 21 May 2008 00:12:02 +1000,
Travis Place wrote:
Without forcing model type to 6stack-dig, the user gets no sound.
Patch is attached, and alsa-info.sh output is at http://pastebin.ca/1023781.
Changelog: Added IDs for the Foxconn P35AX-S mainboard to patch_realtek.c, so that ALC883_6ST_DIG is used by default.
Signed-off-by: Travis Place <wishie at wishie dot net>
It's also in the upstream, too.
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Sorry for the 3 seperate posts Takashi..
Don't worry, I just wanted to inform that these have been already merged.
Is it ok for me to unify the patches (in the future) and send 1 unified changelog ? Or is it preferred that the patches(and thei changelogs) are seperate ?
Depends. I prefer seperate patches as long as they belong to the same logical change. The number of patches usually doesn't matter.
BTW, it'd be appreciated if you add me to Cc so that I can pick up the patch immediately.
thanks,
Takashi
On Mon, 26 May 2008 11:39:22 pm Takashi Iwai wrote:
At Mon, 26 May 2008 23:33:18 +1000,
Travis Place wrote:
On Mon, 26 May 2008 9:04:03 pm Takashi Iwai wrote:
At Wed, 21 May 2008 00:12:02 +1000,
Travis Place wrote:
Without forcing model type to 6stack-dig, the user gets no sound.
Patch is attached, and alsa-info.sh output is at http://pastebin.ca/1023781.
Changelog: Added IDs for the Foxconn P35AX-S mainboard to patch_realtek.c, so that ALC883_6ST_DIG is used by default.
Signed-off-by: Travis Place <wishie at wishie dot net>
It's also in the upstream, too.
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Sorry for the 3 seperate posts Takashi..
Don't worry, I just wanted to inform that these have been already merged.
Is it ok for me to unify the patches (in the future) and send 1 unified changelog ? Or is it preferred that the patches(and thei changelogs) are seperate ?
Depends. I prefer seperate patches as long as they belong to the same logical change. The number of patches usually doesn't matter.
BTW, it'd be appreciated if you add me to Cc so that I can pick up the patch immediately.
Noted, and will do this from now on.
Thanks again.
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (2)
-
Takashi Iwai -
Travis Place