[alsa-devel] [PATCH] omap3: alsa-soc: Remove restrictive check for cpu type
Current check for cpu type is too restrictive leading to failures for other silicons in same family.
The problem was found while testing audio playback on AM37x and AM35x processors. But should exist on OMAP36xx as well.
Signed-off-by: Sanjeev Premi premi@ti.com --- sound/soc/omap/omap-mcbsp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c index 2175f09..84d434a 100644 --- a/sound/soc/omap/omap-mcbsp.c +++ b/sound/soc/omap/omap-mcbsp.c @@ -146,7 +146,7 @@ static int omap_mcbsp_dai_startup(struct snd_pcm_substream *substream, * 2 channels (stereo): size is 128 / 2 = 64 frames (2 * 64 words) * 4 channels: size is 128 / 4 = 32 frames (4 * 32 words) */ - if (cpu_is_omap343x() || cpu_is_omap44xx()) { + if (cpu_is_omap34xx() || cpu_is_omap44xx()) { /* * Rule for the buffer size. We should not allow * smaller buffer than the FIFO size to avoid underruns
On Mon, 14 Mar 2011 19:01:53 +0530 Sanjeev Premi premi@ti.com wrote:
Current check for cpu type is too restrictive leading to failures for other silicons in same family.
The problem was found while testing audio playback on AM37x and AM35x processors. But should exist on OMAP36xx as well.
Signed-off-by: Sanjeev Premi premi@ti.com
sound/soc/omap/omap-mcbsp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
There are two other cpu_is_omap343x tests as well. Care to check them too?
On Mon, 14 Mar 2011 15:55:42 +0200 Jarkko Nikula jhnikula@gmail.com wrote:
On Mon, 14 Mar 2011 19:01:53 +0530 Sanjeev Premi premi@ti.com wrote:
Current check for cpu type is too restrictive leading to failures for other silicons in same family.
The problem was found while testing audio playback on AM37x and AM35x processors. But should exist on OMAP36xx as well.
Signed-off-by: Sanjeev Premi premi@ti.com
sound/soc/omap/omap-mcbsp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
There are two other cpu_is_omap343x tests as well. Care to check them too?
Sorry, only one additional test. I forgot the commit 2686e07 "ASoC: McBSP: get hw params from McBSP driver" that is coming via linux-omap and which removes one test.
-----Original Message----- From: Jarkko Nikula [mailto:jhnikula@gmail.com] Sent: Monday, March 14, 2011 7:31 PM To: Premi, Sanjeev Cc: linux-omap@vger.kernel.org; alsa-devel@alsa-project.org; linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] omap3: alsa-soc: Remove restrictive check for cpu type
On Mon, 14 Mar 2011 15:55:42 +0200 Jarkko Nikula jhnikula@gmail.com wrote:
On Mon, 14 Mar 2011 19:01:53 +0530 Sanjeev Premi premi@ti.com wrote:
Current check for cpu type is too restrictive leading to failures for other silicons in same family.
The problem was found while testing audio playback on AM37x and AM35x processors. But should exist on OMAP36xx as well.
Signed-off-by: Sanjeev Premi premi@ti.com
sound/soc/omap/omap-mcbsp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
There are two other cpu_is_omap343x tests as well. Care to
check them
too?
Sorry, only one additional test. I forgot the commit 2686e07 "ASoC: McBSP: get hw params from McBSP driver" that is coming via linux-omap and which removes one test.
Checking now...
~sanjeev
-- Jarkko
-----Original Message----- From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Premi, Sanjeev Sent: Monday, March 14, 2011 7:47 PM To: Jarkko Nikula Cc: linux-omap@vger.kernel.org; alsa-devel@alsa-project.org; linux-arm-kernel@lists.infradead.org Subject: RE: [PATCH] omap3: alsa-soc: Remove restrictive check for cpu type
-----Original Message----- From: Jarkko Nikula [mailto:jhnikula@gmail.com] Sent: Monday, March 14, 2011 7:31 PM To: Premi, Sanjeev Cc: linux-omap@vger.kernel.org; alsa-devel@alsa-project.org; linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] omap3: alsa-soc: Remove restrictive check for cpu type
On Mon, 14 Mar 2011 15:55:42 +0200 Jarkko Nikula jhnikula@gmail.com wrote:
On Mon, 14 Mar 2011 19:01:53 +0530 Sanjeev Premi premi@ti.com wrote:
Current check for cpu type is too restrictive leading to failures for other silicons in same family.
The problem was found while testing audio playback on AM37x and AM35x processors. But should exist on OMAP36xx as well.
Signed-off-by: Sanjeev Premi premi@ti.com
sound/soc/omap/omap-mcbsp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
There are two other cpu_is_omap343x tests as well. Care to
check them
too?
Sorry, only one additional test. I forgot the commit 2686e07 "ASoC: McBSP: get hw params from McBSP driver" that is coming via
linux-omap
and which removes one test.
Checking now...
Other check shouldn't be there are well... Had asked someone (off-this -list) to help me test the change - but seems to be in todo.
Will test it myself and post updated patch today...
~sanjeev
-- Jarkko --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
participants (3)
-
Jarkko Nikula -
Premi, Sanjeev -
Sanjeev Premi