[alsa-devel] [PATCH 0/4] Fixup hda-emu so David's test suite does not fail
So; from what I can see, all newly discovered errors looked like errors in hda-emu rather than errors in the codec. But I don't mind having a second confirmation on that, because I'm not totally sure.
With these patches, my test suite is again back to 0 errors. :-)
David Henningsson (4): hda-emu: Enable CONFIG_SND_DYNAMIC_MINORS hda-emu: Add verbs for old Nvidia HDMI 8ch 7x hda-emu: Allow some more codec IDs to use ATI HDMI special verbs hda-emu/tester: Fix calculation of machines
hda-spec.c | 17 +++++++++++++++++ include/codec_config.h | 2 ++ tester/summary.py | 4 +++- 3 files changed, 22 insertions(+), 1 deletion(-)
This is enabled on any modern distro and necessary for modern HDMI stuff (with more than two outputs) to function correctly.
Signed-off-by: David Henningsson david.henningsson@canonical.com --- include/codec_config.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/codec_config.h b/include/codec_config.h index 78bb04d..a5b4919 100644 --- a/include/codec_config.h +++ b/include/codec_config.h @@ -12,3 +12,5 @@ #define CONFIG_SND_HDA_INPUT_BEEP
#define CONFIG_SND_HDA_ENABLE_REALTEK_QUIRKS + +#define CONFIG_SND_DYNAMIC_MINORS
The driver sends these verbs on purpose. I can't verify that it is correct to do so, but I hope the driver is doing the right thing here.
Signed-off-by: David Henningsson david.henningsson@canonical.com --- hda-spec.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
diff --git a/hda-spec.c b/hda-spec.c index fe2ff36..b03d06a 100644 --- a/hda-spec.c +++ b/hda-spec.c @@ -263,6 +263,14 @@ static struct xhda_verb_table amdhdmi_verbs[] = { { } /* terminator */ };
+static struct xhda_verb_table nvhdmi_8ch_7x_verbs[] = { + { 0xf79, set_cached_verb, "nvhdmi_set_channel_allocation" }, + { 0xf7a, set_cached_verb, "nvhdmi_set_info_frame_checksum" }, + { 0xf98, set_cached_verb, "nvhdmi_set_audio_protection_on" }, + { 0xf99, set_cached_verb, "nvhdmi_set_audio_protection_off" }, + { } /* terminator */ +}; + /* */
@@ -428,6 +436,12 @@ static struct verb_ext_list extensions[] = {
{ .id = 0x1002aa01, .verbs = amdhdmi_verbs },
+ { .id = 0x10de0002, .verbs = nvhdmi_8ch_7x_verbs }, + { .id = 0x10de0003, .verbs = nvhdmi_8ch_7x_verbs }, + { .id = 0x10de0005, .verbs = nvhdmi_8ch_7x_verbs }, + { .id = 0x10de0006, .verbs = nvhdmi_8ch_7x_verbs }, + { .id = 0x10de0007, .verbs = nvhdmi_8ch_7x_verbs }, + { } };
Signed-off-by: David Henningsson david.henningsson@canonical.com --- hda-spec.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/hda-spec.c b/hda-spec.c index b03d06a..58dd87a 100644 --- a/hda-spec.c +++ b/hda-spec.c @@ -434,6 +434,9 @@ static struct verb_ext_list extensions[] = { { .id = 0x11060446, .verbs = vt2002p_verbs }, { .id = 0x11068446, .verbs = vt2002p_verbs },
+ { .id = 0x1002793c, .verbs = amdhdmi_verbs }, + { .id = 0x10027919, .verbs = amdhdmi_verbs }, + { .id = 0x1002791a, .verbs = amdhdmi_verbs }, { .id = 0x1002aa01, .verbs = amdhdmi_verbs },
{ .id = 0x10de0002, .verbs = nvhdmi_8ch_7x_verbs },
Previously, if a machine had a modem codec, it was not included in the total count of machines.
Signed-off-by: David Henningsson david.henningsson@canonical.com --- tester/summary.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tester/summary.py b/tester/summary.py index 640d1c1..4bf53b6 100755 --- a/tester/summary.py +++ b/tester/summary.py @@ -90,7 +90,9 @@ def main(): if line.find("is a modem codec, aborting"): skip_this = True
- if (not skip_this) and (r.errors > 0 or r.warnings > 0): + if skip_this: + skip_this = False + elif (r.errors > 0 or r.warnings > 0): fail_this = True errors += r.errors warnings += r.warnings
At Thu, 4 Sep 2014 16:21:22 +0200, David Henningsson wrote:
So; from what I can see, all newly discovered errors looked like errors in hda-emu rather than errors in the codec. But I don't mind having a second confirmation on that, because I'm not totally sure.
With these patches, my test suite is again back to 0 errors. :-)
All look good to me, so applied now. Thanks!
Takashi
David Henningsson (4): hda-emu: Enable CONFIG_SND_DYNAMIC_MINORS hda-emu: Add verbs for old Nvidia HDMI 8ch 7x hda-emu: Allow some more codec IDs to use ATI HDMI special verbs hda-emu/tester: Fix calculation of machines
hda-spec.c | 17 +++++++++++++++++ include/codec_config.h | 2 ++ tester/summary.py | 4 +++- 3 files changed, 22 insertions(+), 1 deletion(-)
-- 1.9.1
participants (2)
-
David Henningsson -
Takashi Iwai