[alsa-devel] [PATCH 2.6.27?] ASoC: Correct inverted Mic PGA Switch control in wm8510 driver
Mic PGA Switch should be inverted in the WM8510 driver but isn't.
Reported-by: ext-jukka.hynninen@vaisala.com Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com ---
This bugfix applies to 2.6.27 but the issue is not very severe - it'd be good to get it in but it's not critical.
sound/soc/codecs/wm8510.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/codecs/wm8510.c index 75ed041..f644da6 100644 --- a/sound/soc/codecs/wm8510.c +++ b/sound/soc/codecs/wm8510.c @@ -199,7 +199,7 @@ SOC_DAPM_SINGLE("PCM Playback Switch", WM8510_MONOMIX, 0, 1, 0), };
static const struct snd_kcontrol_new wm8510_boost_controls[] = { -SOC_DAPM_SINGLE("Mic PGA Switch", WM8510_INPPGA, 6, 1, 0), +SOC_DAPM_SINGLE("Mic PGA Switch", WM8509_INPPGA, 6, 1, 1), SOC_DAPM_SINGLE("Aux Volume", WM8510_ADCBOOST, 0, 7, 0), SOC_DAPM_SINGLE("Mic Volume", WM8510_ADCBOOST, 4, 7, 0), };
Mark Brown wrote:
Mic PGA Switch should be inverted in the WM8510 driver but isn't.
Reported-by: ext-jukka.hynninen@vaisala.com Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
This bugfix applies to 2.6.27 but the issue is not very severe - it'd be good to get it in but it's not critical.
sound/soc/codecs/wm8510.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/codecs/wm8510.c index 75ed041..f644da6 100644 --- a/sound/soc/codecs/wm8510.c +++ b/sound/soc/codecs/wm8510.c @@ -199,7 +199,7 @@ SOC_DAPM_SINGLE("PCM Playback Switch", WM8510_MONOMIX, 0, 1, 0), };
static const struct snd_kcontrol_new wm8510_boost_controls[] = { -SOC_DAPM_SINGLE("Mic PGA Switch", WM8510_INPPGA, 6, 1, 0), +SOC_DAPM_SINGLE("Mic PGA Switch", WM8509_INPPGA, 6, 1, 1), SOC_DAPM_SINGLE("Aux Volume", WM8510_ADCBOOST, 0, 7, 0), SOC_DAPM_SINGLE("Mic Volume", WM8510_ADCBOOST, 4, 7, 0), };
Why the WM509 prefix instead of WM8510?
On Fri, Oct 03, 2008 at 10:20:53AM -0700, Troy Kisky wrote:
Why the WM509 prefix instead of WM8510?
Gah. Because I sent an incorrect, buggy, version of the patch. Trying to do too many things at once :/
Takashi, please don't apply.
At Fri, 3 Oct 2008 18:47:14 +0100, Mark Brown wrote:
On Fri, Oct 03, 2008 at 10:20:53AM -0700, Troy Kisky wrote:
Why the WM509 prefix instead of WM8510?
Gah. Because I sent an incorrect, buggy, version of the patch. Trying to do too many things at once :/
Takashi, please don't apply.
OK.
Will you send a correct one later, or is the fix totally bogus?
Takashi
participants (3)
-
Mark Brown
-
Takashi Iwai
-
Troy Kisky