[alsa-devel] [PATCH] pxa2xx-ac97: fix reset gpio mode setting
Signed-off-by: Mike Rapoport mike@compulab.co.il --- sound/arm/pxa2xx-ac97-lib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c index a2c12d1..6fdca97 100644 --- a/sound/arm/pxa2xx-ac97-lib.c +++ b/sound/arm/pxa2xx-ac97-lib.c @@ -65,7 +65,7 @@ static void set_resetgpio_mode(int resetgpio_action) switch (resetgpio_action) { case RESETGPIO_NORMAL_ALTFUNC: if (reset_gpio == 113) - mode = 113 | GPIO_OUT | GPIO_DFLT_LOW; + mode = 113 | GPIO_ALT_FN_2_OUT; if (reset_gpio == 95) mode = 95 | GPIO_ALT_FN_1_OUT; break;
On Mon, May 11, 2009 at 6:11 PM, Mike Rapoport mike@compulab.co.il wrote:
Signed-off-by: Mike Rapoport mike@compulab.co.il
Acked-by: Eric Miao eric.miao@marvell.com
Just curious, this didn't cause any issue in the past :)
sound/arm/pxa2xx-ac97-lib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c index a2c12d1..6fdca97 100644 --- a/sound/arm/pxa2xx-ac97-lib.c +++ b/sound/arm/pxa2xx-ac97-lib.c @@ -65,7 +65,7 @@ static void set_resetgpio_mode(int resetgpio_action) switch (resetgpio_action) { case RESETGPIO_NORMAL_ALTFUNC: if (reset_gpio == 113)
- mode = 113 | GPIO_OUT | GPIO_DFLT_LOW;
- mode = 113 | GPIO_ALT_FN_2_OUT;
if (reset_gpio == 95) mode = 95 | GPIO_ALT_FN_1_OUT; break; -- 1.5.6.4
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Eric Miao wrote:
On Mon, May 11, 2009 at 6:11 PM, Mike Rapoport mike@compulab.co.il wrote:
Signed-off-by: Mike Rapoport mike@compulab.co.il
Acked-by: Eric Miao eric.miao@marvell.com
Just curious, this didn't cause any issue in the past :)
It's 2.6.30 material so there's not much past :)
sound/arm/pxa2xx-ac97-lib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c index a2c12d1..6fdca97 100644 --- a/sound/arm/pxa2xx-ac97-lib.c +++ b/sound/arm/pxa2xx-ac97-lib.c @@ -65,7 +65,7 @@ static void set_resetgpio_mode(int resetgpio_action) switch (resetgpio_action) { case RESETGPIO_NORMAL_ALTFUNC: if (reset_gpio == 113)
mode = 113 | GPIO_OUT | GPIO_DFLT_LOW;
mode = 113 | GPIO_ALT_FN_2_OUT; if (reset_gpio == 95) mode = 95 | GPIO_ALT_FN_1_OUT; break;-- 1.5.6.4
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Dne pondělí 11 Květen 2009 12:51:14 Eric Miao napsal(a):
On Mon, May 11, 2009 at 6:11 PM, Mike Rapoport mike@compulab.co.il wrote:
Signed-off-by: Mike Rapoport mike@compulab.co.il
Acked-by: Eric Miao eric.miao@marvell.com
Just curious, this didn't cause any issue in the past :)
It's probably because all machines set AFN with pxa2xx_mfp_config in start-up. I have seen this when I tried to locate Palm AC97 problem after resume...
Tomas Cech
Eric Miao eric.y.miao@gmail.com writes:
On Mon, May 11, 2009 at 6:11 PM, Mike Rapoport mike@compulab.co.il wrote:
Signed-off-by: Mike Rapoport mike@compulab.co.il
Acked-by: Eric Miao eric.miao@marvell.com
Argh, that was my screw up ... Let's forward that to Mark, and see if that can make it into the 2.6.30 fixes.
Acked-by: Robert Jarzmik robert.jarzmik@free.fr
-- Robert
Just curious, this didn't cause any issue in the past :)
sound/arm/pxa2xx-ac97-lib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c index a2c12d1..6fdca97 100644 --- a/sound/arm/pxa2xx-ac97-lib.c +++ b/sound/arm/pxa2xx-ac97-lib.c @@ -65,7 +65,7 @@ static void set_resetgpio_mode(int resetgpio_action) switch (resetgpio_action) { case RESETGPIO_NORMAL_ALTFUNC: if (reset_gpio == 113)
- mode = 113 | GPIO_OUT | GPIO_DFLT_LOW;
- mode = 113 | GPIO_ALT_FN_2_OUT;
if (reset_gpio == 95) mode = 95 | GPIO_ALT_FN_1_OUT; break; -- 1.5.6.4
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-- Cheers
- eric
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On Mon, May 11, 2009 at 01:11:38PM +0300, Mike Rapoport wrote:
Signed-off-by: Mike Rapoport mike@compulab.co.il
Applied, thanks. Please CC me on things...
On Tue, May 12, 2009 at 2:04 AM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Mon, May 11, 2009 at 01:11:38PM +0300, Mike Rapoport wrote:
Signed-off-by: Mike Rapoport mike@compulab.co.il
Applied, thanks. Please CC me on things...
My fault, I forgot to include you, sorry about that.
participants (5)
-
Eric Miao -
Mark Brown -
Mike Rapoport -
Robert Jarzmik -
Tomas 'Sleep_Walker' Cech