Re: PCI SSID and Codec SSID collision?
Hi, I'm curious about the reasons for the fixup table to be the same for PCI and Codec SSIDs and if the PCI SSID is usually more important for it to be checked before the Codec. Anyway, would a simple conditional statement to match these exact PCI and Codec SSID to set the fixup manually be enough? There seems to already exist a manual fix for TX300 and ROG Strix G17 there (not the same kind of fix and with a FIXME comment, though). I have this exact laptop model and would like to try to contribute to the code if it's not too complicated.
On Fri, 23 Feb 2024 15:41:26 +0100, Willian Wang wrote:
Hi, I'm curious about the reasons for the fixup table to be the same for PCI and Codec SSIDs and if the PCI SSID is usually more important for it to be checked before the Codec.
Sometimes the manufacturers are lazy and didn't check the conflict in their own products :-<
Anyway, would a simple conditional statement to match these exact PCI and Codec SSID to set the fixup manually be enough? There seems to already exist a manual fix for TX300 and ROG Strix G17 there (not the same kind of fix and with a FIXME comment, though). I have this exact laptop model and would like to try to contribute to the code if it's not too complicated.
Yes, that's my suggestion. I don't have the data of the other 17aa:3802, but I guess it should have a different codec SSID.
thanks,
Takashi
Hi Willian,
On Fri, 2024-02-23 at 11:41 -0300, Willian Wang wrote:
Hi, I'm curious about the reasons for the fixup table to be the same for PCI and Codec SSIDs and if the PCI SSID is usually more important for it to be checked before the Codec. Anyway, would a simple conditional statement to match these exact PCI and Codec SSID to set the fixup manually be enough? There seems to already exist a manual fix for TX300 and ROG Strix G17 there (not the same kind of fix and with a FIXME comment, though). I have this exact laptop model and would like to try to contribute to the code if it's not too complicated.
I think it could be simple, like this function: alc298_fixup_lenovo_c940_duet7
Feel free to contribute. Easier for you to test.
This can help: The output of DuetITL 2021 amixer: https://linux-hardware.org/?probe=19173612af&log=amixer
Regards, Gergo
Here is my attempt. I hope it doesn't break with the DuetITL mode, I chose to create a special case for it instead of otherwise because there is an european version of the 14IRP8 with different codec SSID (https://bugzilla.kernel.org/show_bug.cgi?id=208555#c778, 0x17aa38bf vs 0x17aa38be).
This is my first time contributing with a commit and I'm not sure if I did everything correctly so please let me know. I also don't know if I should send it to a specific email with you as CC or something like that.
On Fri, Feb 23, 2024 at 12:10 PM Gergo Koteles soyer@irl.hu wrote:
Hi Willian,
On Fri, 2024-02-23 at 11:41 -0300, Willian Wang wrote:
Hi, I'm curious about the reasons for the fixup table to be the same for PCI and Codec SSIDs and if the PCI SSID is usually more important for it to be checked before the Codec. Anyway, would a simple conditional statement to match these exact PCI and Codec SSID to set the fixup manually be enough? There seems to already exist a manual fix for TX300 and ROG Strix G17 there (not the same kind of fix and with a FIXME comment, though). I have this exact laptop model and would like to try to contribute to the code if it's not too complicated.
I think it could be simple, like this function: alc298_fixup_lenovo_c940_duet7
Feel free to contribute. Easier for you to test.
This can help: The output of DuetITL 2021 amixer: https://linux-hardware.org/?probe=19173612af&log=amixer
Regards, Gergo
On Fri, 23 Feb 2024 22:55:40 +0100, Willian Wang wrote:
Here is my attempt. I hope it doesn't break with the DuetITL mode, I chose to create a special case for it instead of otherwise because there is an european version of the 14IRP8 with different codec SSID (https://bugzilla.kernel.org/show_bug.cgi?id=208555#c778, 0x17aa38bf vs 0x17aa38be).
This is my first time contributing with a commit and I'm not sure if I did everything correctly so please let me know. I also don't know if I should send it to a specific email with you as CC or something like that.
Looks good. And yes, could you resubmit only the patch without hanging on the thread?
thanks,
Takashi
participants (3)
-
Gergo Koteles -
Takashi Iwai -
Willian Wang