At Wed, 10 Oct 2012 07:36:43 +0800, Fengguang Wu wrote:

Hi Takashi,

FYI, there *will* be new compile warnings in

672a112 ALSA: pcxhr - Kill tasklets

sound/pci/pcxhr/pcxhr.c: In function 'pcxhr_prepare': sound/pci/pcxhr/pcxhr.c:916:2: warning: 'flush_work_sync' is deprecated (declared at include/linux/workqueue.h:448) [-Wdeprecated-declarations] sound/pci/pcxhr/pcxhr.c: In function 'pcxhr_hw_free': sound/pci/pcxhr/pcxhr.c:978:2: warning: 'flush_work_sync' is deprecated (declared at include/linux/workqueue.h:448) [-Wdeprecated-declarations]

Thanks, fixed now.

Takashi

vim +916 sound/pci/pcxhr/pcxhr.c

e12229b4 Markus Bollinger 2005-12-06 901 e12229b4 Markus Bollinger 2005-12-06 902 /* e12229b4 Markus Bollinger 2005-12-06 903 * prepare callback for all pcms e12229b4 Markus Bollinger 2005-12-06 904 */ e12229b4 Markus Bollinger 2005-12-06 905 static int pcxhr_prepare(struct snd_pcm_substream *subs) e12229b4 Markus Bollinger 2005-12-06 906 { e12229b4 Markus Bollinger 2005-12-06 907 struct snd_pcxhr *chip = snd_pcm_substream_chip(subs); e12229b4 Markus Bollinger 2005-12-06 908 struct pcxhr_mgr *mgr = chip->mgr; e12229b4 Markus Bollinger 2005-12-06 909 int err = 0; e12229b4 Markus Bollinger 2005-12-06 910 e12229b4 Markus Bollinger 2005-12-06 911 snd_printdd("pcxhr_prepare : period_size(%lx) periods(%x) buffer_size(%lx)\n", e12229b4 Markus Bollinger 2005-12-06 912 subs->runtime->period_size, subs->runtime->periods, e12229b4 Markus Bollinger 2005-12-06 913 subs->runtime->buffer_size); e12229b4 Markus Bollinger 2005-12-06 914 672a1128 Takashi Iwai 2011-06-14 915 cancel_work_sync(&mgr->timer_work); 672a1128 Takashi Iwai 2011-06-14 @916 flush_work_sync(&mgr->trigger_work); 672a1128 Takashi Iwai 2011-06-14 917 62932df8 Ingo Molnar 2006-01-16 918 mutex_lock(&mgr->setup_mutex); e12229b4 Markus Bollinger 2005-12-06 919 e12229b4 Markus Bollinger 2005-12-06 920 do { e12229b4 Markus Bollinger 2005-12-06 921 /* only the first stream can choose the sample rate */ e12229b4 Markus Bollinger 2005-12-06 922 /* set the clock only once (first stream) */ 8937fd88 Takashi Iwai 2006-01-10 923 if (mgr->sample_rate != subs->runtime->rate) { e12229b4 Markus Bollinger 2005-12-06 924 err = pcxhr_set_clock(mgr, subs->runtime->rate);

---

0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation