[alsa-devel] [PATCH 0/2] soundwire: Kconfig/build improvements
The Intel kbuild test reported issues with COMPILE_TEST or cross-compilation when SOF is enabled, fix. This has no functional impact.
Pierre-Louis Bossart (2): soundwire: intel: add missing headers for cross-compilation soundwire: intel: remove X86 dependency
drivers/soundwire/Kconfig | 2 +- drivers/soundwire/intel.c | 1 + drivers/soundwire/intel_init.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-)
readl/writel and ioread32 are used without the relevant headers, fix.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com --- drivers/soundwire/intel.c | 1 + drivers/soundwire/intel_init.c | 1 + 2 files changed, 2 insertions(+)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index f1e38a293967..bcc5077b2814 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -10,6 +10,7 @@ #include <linux/delay.h> #include <linux/module.h> #include <linux/interrupt.h> +#include <linux/io.h> #include <linux/platform_device.h> #include <sound/pcm_params.h> #include <sound/soc.h> diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c index b74c2f144962..d488c44fcbae 100644 --- a/drivers/soundwire/intel_init.c +++ b/drivers/soundwire/intel_init.c @@ -9,6 +9,7 @@
#include <linux/acpi.h> #include <linux/export.h> +#include <linux/iomap.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/soundwire/sdw_intel.h>
This is not needed and may generate unmet dependencies when COMPILE_TEST is used for SOF.
ACPI is required, and should be tested when selecting this option.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com --- drivers/soundwire/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig index f518273cfbe3..26902023f4e7 100644 --- a/drivers/soundwire/Kconfig +++ b/drivers/soundwire/Kconfig @@ -23,7 +23,7 @@ config SOUNDWIRE_CADENCE config SOUNDWIRE_INTEL tristate "Intel SoundWire Master driver" select SOUNDWIRE_CADENCE - depends on X86 && ACPI && SND_SOC + depends on ACPI && SND_SOC help SoundWire Intel Master driver. If you have an Intel platform which has a SoundWire Master then
On 9/16/19 1:57 PM, Pierre-Louis Bossart wrote:
The Intel kbuild test reported issues with COMPILE_TEST or cross-compilation when SOF is enabled, fix. This has no functional impact.
Vinod, if you are back at your desk, those patches are almost a month old. thanks!
Pierre-Louis Bossart (2): soundwire: intel: add missing headers for cross-compilation soundwire: intel: remove X86 dependency
drivers/soundwire/Kconfig | 2 +- drivers/soundwire/intel.c | 1 + drivers/soundwire/intel_init.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-)
participants (2)
-
Pierre-Louis Bossart -
Vinod Koul