[alsa-devel] SoC/Codecs/SGTL5000 - Non working MIC_BIAS Voltage settings
Hello, in attachment there is a small patch to ensure the correct register value for MIC BIAS Voltage.
Best regards
Hello, I didn't receive any feedback about this posting...
On 06/12/2015 06:13 PM, gianluca wrote:
Hello, in attachment there is a small patch to ensure the correct register value for MIC BIAS Voltage.
diff -Nru linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c linux-4.0.5/sound/soc/codecs/sgtl5000.c --- linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c 2015-06-06 17:21:22.000000000 +0200 +++ linux-4.0.5/sound/soc/codecs/sgtl5000.c 2015-06-12 18:09:38.363381087 +0200 @@ -1339,8 +1339,8 @@ sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT);
snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL, - SGTL5000_BIAS_R_MASK, - sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT); + SGTL5000_BIAS_VOLT_MASK, + sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT); /* * disable DAP * TODO:
Hi Gianluca
On Wed, Jun 17, 2015 at 8:20 AM, gianluca gianlucarenzi@eurekelettronica.it wrote:
Hello, I didn't receive any feedback about this posting...
On 06/12/2015 06:13 PM, gianluca wrote:
Hello, in attachment there is a small patch to ensure the correct register value for MIC BIAS Voltage.
diff -Nru linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c linux-4.0.5/sound/soc/codecs/sgtl5000.c --- linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c 2015-06-06 17:21:22.000000000 +0200 +++ linux-4.0.5/sound/soc/codecs/sgtl5000.c 2015-06-12 18:09:38.363381087 +0200 @@ -1339,8 +1339,8 @@ sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT);
snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL,
SGTL5000_BIAS_R_MASK,sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT);
SGTL5000_BIAS_VOLT_MASK,sgtl5000->micbias_voltage <<SGTL5000_BIAS_VOLT_SHIFT); /*
According to what I see look fine. Fabio will comment on it. You should adjust the subject like: ASoC: sgtl5000: <description here>
Michael
* disable DAP * TODO:
Hi Gianluca,
On Wed, Jun 17, 2015 at 4:20 AM, gianluca gianlucarenzi@eurekelettronica.it wrote:
Hello, I didn't receive any feedback about this posting...
Thanks for your patch.
Please don't post patches as attachments. Better send them with 'git send-email'. Documentation/SubmittingPatches has the information you need.
You also need to provide a commit log, proper Subject and your Signed-off-by.
Then Cc the maintainer: ./scripts/get_maintainer.pl <yourpatch> can help you listing the appropriate folks.
Regards,
Fabio Estevam
Hi
On Jun 17, 2015 3:03 PM, "Fabio Estevam" festevam@gmail.com wrote:
Hi Gianluca,
On Wed, Jun 17, 2015 at 4:20 AM, gianluca gianlucarenzi@eurekelettronica.it wrote:
Hello, I didn't receive any feedback about this posting...
Thanks for your patch.
Please don't post patches as attachments. Better send them with 'git send-email'. Documentation/SubmittingPatches has the information you need.
You also need to provide a commit log, proper Subject and your
Signed-off-by.
Then Cc the maintainer: ./scripts/get_maintainer.pl <yourpatch> can help you listing the appropriate folks.
Already inform him about rule ;)
He should send up a new one
Michael
Regards,
Fabio Estevam _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
The patch
ASoC: sgtl5000: fix wrong register MIC_BIAS_VOLTAGE setup on probe
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From e256da84a04ea31c3c215997c847609af224e8f4 Mon Sep 17 00:00:00 2001
From: Gianluca Renzi gianlucarenzi@eurekelettronica.it Date: Fri, 25 Sep 2015 21:33:41 +0200 Subject: [PATCH] ASoC: sgtl5000: fix wrong register MIC_BIAS_VOLTAGE setup on probe
Signed-off-by: Gianluca Renzi gianlucarenzi@eurekelettronica.it Signed-off-by: Mark Brown broonie@kernel.org Cc: stable@vger.kernel.org --- sound/soc/codecs/sgtl5000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 6e7843e..f540f82 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1376,8 +1376,8 @@ static int sgtl5000_probe(struct snd_soc_codec *codec) sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT);
snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL, - SGTL5000_BIAS_R_MASK, - sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT); + SGTL5000_BIAS_VOLT_MASK, + sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT); /* * disable DAP * TODO:
participants (4)
-
Fabio Estevam -
gianluca -
Mark Brown -
Michael Trimarchi