[alsa-devel] [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver
The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.
Signed-off-by: Daniel Mack zonque@gmail.com Cc: Mark Brown broonie@opensource.wolfsonmicro.com Cc: Liam Girdwood lrg@slimlogic.co.uk --- sound/soc/codecs/cs4270.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index 0206a17..6cc8678 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -636,10 +636,7 @@ static int cs4270_soc_resume(struct snd_soc_codec *codec) #endif /* CONFIG_PM */
/* - * ASoC codec device structure - * - * Assign this variable to the codec_dev field of the machine driver's - * snd_soc_device structure. + * ASoC codec driver structure */ static const struct snd_soc_codec_driver soc_codec_device_cs4270 = { .probe = cs4270_probe,
On 25/05/11 08:53, Daniel Mack wrote:
The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.
Signed-off-by: Daniel Mack zonque@gmail.com Cc: Mark Brown broonie@opensource.wolfsonmicro.com Cc: Liam Girdwood lrg@slimlogic.co.uk
sound/soc/codecs/cs4270.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
Acked-by: Liam Girdwood lrg@ti.com
On Wed, May 25, 2011 at 09:53:12AM +0200, Daniel Mack wrote:
The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.
Signed-off-by: Daniel Mack zonque@gmail.com Cc: Mark Brown broonie@opensource.wolfsonmicro.com Cc: Liam Girdwood lrg@slimlogic.co.uk
CCing in Timur for his review.
sound/soc/codecs/cs4270.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index 0206a17..6cc8678 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -636,10 +636,7 @@ static int cs4270_soc_resume(struct snd_soc_codec *codec) #endif /* CONFIG_PM */
/*
- ASoC codec device structure
- Assign this variable to the codec_dev field of the machine driver's
- snd_soc_device structure.
*/
- ASoC codec driver structure
static const struct snd_soc_codec_driver soc_codec_device_cs4270 = { .probe = cs4270_probe, -- 1.7.5.1
On Wed, May 25, 2011 at 2:53 AM, Daniel Mack zonque@gmail.com wrote:
The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.
Signed-off-by: Daniel Mack zonque@gmail.com Cc: Mark Brown broonie@opensource.wolfsonmicro.com Cc: Liam Girdwood lrg@slimlogic.co.uk
Acked-by: Timur Tabi timur@freescale.com
On Wed, May 25, 2011 at 09:53:12AM +0200, Daniel Mack wrote:
The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.
Applied, thanks.
participants (4)
-
Daniel Mack -
Liam Girdwood -
Mark Brown -
Tabi Timur-B04825