[alsa-devel] [[PATCH] ALSA: In Freescale ESAI driver xDxDC bits in xCCR registers is 5 bits width not 4
Signed-off-by: Aurelien BOUIN a_bouin@yahoo.fr
diff --git a/sound/soc/fsl/fsl_esai.h b/sound/soc/fsl/fsl_esai.h index 91a550f..5e793bb 100644 --- a/sound/soc/fsl/fsl_esai.h +++ b/sound/soc/fsl/fsl_esai.h @@ -302,7 +302,7 @@ #define ESAI_xCCR_xFP_MASK (((1 << ESAI_xCCR_xFP_WIDTH) - 1) << ESAI_xCCR_xFP_SHIFT) #define ESAI_xCCR_xFP(v) ((((v) - 1) << ESAI_xCCR_xFP_SHIFT) & ESAI_xCCR_xFP_MASK) #define ESAI_xCCR_xDC_SHIFT 9 -#define ESAI_xCCR_xDC_WIDTH 4 +#define ESAI_xCCR_xDC_WIDTH 5 #define ESAI_xCCR_xDC_MASK (((1 << ESAI_xCCR_xDC_WIDTH) - 1) << ESAI_xCCR_xDC_SHIFT) #define ESAI_xCCR_xDC(v) ((((v) - 1) << ESAI_xCCR_xDC_SHIFT) & ESAI_xCCR_xDC_MASK) #define ESAI_xCCR_xPSR_SHIFT 8
Hi Aurelien,
On Thu, Dec 18, 2014 at 12:31 PM, Aurelien BOUIN a_bouin@yahoo.fr wrote:
Signed-off-by: Aurelien BOUIN a_bouin@yahoo.fr
diff --git a/sound/soc/fsl/fsl_esai.h b/sound/soc/fsl/fsl_esai.h index 91a550f..5e793bb 100644 --- a/sound/soc/fsl/fsl_esai.h +++ b/sound/soc/fsl/fsl_esai.h @@ -302,7 +302,7 @@ #define ESAI_xCCR_xFP_MASK (((1 << ESAI_xCCR_xFP_WIDTH) - 1) << ESAI_xCCR_xFP_SHIFT) #define ESAI_xCCR_xFP(v) ((((v) - 1) << ESAI_xCCR_xFP_SHIFT) & ESAI_xCCR_xFP_MASK) #define ESAI_xCCR_xDC_SHIFT 9 -#define ESAI_xCCR_xDC_WIDTH 4 +#define ESAI_xCCR_xDC_WIDTH 5
The content of the patch is correct, but you need to improve a few things:
- Subject should be something like: ASoC: fsl_esai: Fix ESAI_xCCR_xDC_WIDTH definition. In the two versions you sent you add an unneeded "["
- It is always good to add a commit log like:
"According to the mx6 reference manual the TDC and RDC field of registers ESAI_TCCR and ESAI_RCCR have a width of 5 bits, not 4".
- You missed to Cc the esai driver maintainer Nicolin Chen.
After you fix address these comments you can send a v2 of this patch.
participants (2)
-
Aurelien BOUIN -
Fabio Estevam