[alsa-devel] ALC298 headset mode support
Hi Takashi,
I finished the alc298 headset mode supported. But it only tested via our develop system.
BR, Kailang
At Mon, 11 May 2015 08:30:28 +0000, Kailang wrote:
Hi Takashi,
I finished the alc298 headset mode supported. But it only tested via our develop system.
....
@@ -3801,6 +3804,8 @@ static void alc_headset_mode_ctia(struct hda_codec *codec) case 0x10ec0283: alc_process_coef_fw(codec, coef0233); break;
- case 0x10ec0298:
alc_update_coef_idx(codec, 0x8e, 0x0070, 0x0020);
I suppose you didn't forget break in the above, right? If so, add a comment like /* fallthrough */ to indicate that it's the intentional code. Ditto for other similar lines.
thanks,
Takashi
Hi Takashi,
New patch attached. ALC298 hidden register was very similar to ALC286/ALC288. Many Thanks. ^^
BR, Kailang
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Monday, May 11, 2015 8:35 PM To: Kailang Cc: (alsa-devel@alsa-project.org) Subject: Re: ALC298 headset mode support
At Mon, 11 May 2015 08:30:28 +0000, Kailang wrote:
Hi Takashi,
I finished the alc298 headset mode supported. But it only tested via our develop system.
....
@@ -3801,6 +3804,8 @@ static void
alc_headset_mode_ctia(struct hda_codec *codec)
case 0x10ec0283: alc_process_coef_fw(codec, coef0233); break;
- case 0x10ec0298:
alc_update_coef_idx(codec, 0x8e, 0x0070, 0x0020);I suppose you didn't forget break in the above, right?
Yes.
If so, add a comment like /* fallthrough */ to indicate that it's the intentional code. Ditto for other similar lines.
thanks,
Takashi
------Please consider the environment before printing this e-mail.
At Tue, 12 May 2015 09:19:56 +0000, Kailang wrote:
Hi Takashi,
New patch attached. ALC298 hidden register was very similar to ALC286/ALC288. Many Thanks. ^^
BR, Kailang
OK, applied now.
thanks,
Takashi
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Monday, May 11, 2015 8:35 PM To: Kailang Cc: (alsa-devel@alsa-project.org) Subject: Re: ALC298 headset mode support
At Mon, 11 May 2015 08:30:28 +0000, Kailang wrote:
Hi Takashi,
I finished the alc298 headset mode supported. But it only tested via our develop system.
....
@@ -3801,6 +3804,8 @@ static void
alc_headset_mode_ctia(struct hda_codec *codec)
case 0x10ec0283: alc_process_coef_fw(codec, coef0233); break;
- case 0x10ec0298:
alc_update_coef_idx(codec, 0x8e, 0x0070, 0x0020);I suppose you didn't forget break in the above, right?
Yes.
If so, add a comment like /* fallthrough */ to indicate that it's the intentional code. Ditto for other similar lines.
thanks,
Takashi
------Please consider the environment before printing this e-mail.
[2 0001-alc298-headset-mode.patch <application/octet-stream (base64)>]
participants (2)
-
Kailang -
Takashi Iwai