[alsa-devel] [PATCH 1/1] hdsp: allow firmware loading from inside the kernel
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
From: Raphaël Doursenaud rdoursenaud@free.fr
Allow the use of the FIRMWARE_IN_KERNEL option with hdsp cards and in-kernel driver. Also corrected a typo in the comment.
Signed-off-by: Raphael Doursenaud rdoursenaud@free.fr - --- sound/pci/rme9652/hdsp.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 314e735..d0d4629 100644 - --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -402,9 +402,9 @@ MODULE_FIRMWARE("digiface_firmware_rev11.bin"); #define HDSP_DMA_AREA_BYTES ((HDSP_MAX_CHANNELS+1) * HDSP_CHANNEL_BUFFER_BYTES) #define HDSP_DMA_AREA_KILOBYTES (HDSP_DMA_AREA_BYTES/1024)
- -/* use hotplug firmeare loader? */ +/* use hotplug firmware loader? */ #if defined(CONFIG_FW_LOADER) || defined(CONFIG_FW_LOADER_MODULE) - -#if !defined(HDSP_USE_HWDEP_LOADER) && !defined(CONFIG_SND_HDSP) +#if !defined(HDSP_USE_HWDEP_LOADER) #define HDSP_FW_LOADER #endif #endif
- -- Raphaël Doursenaud
At Tue, 12 May 2009 08:16:08 +0200, Raphaël Doursenaud wrote:
From: Raphaël Doursenaud rdoursenaud@free.fr
Allow the use of the FIRMWARE_IN_KERNEL option with hdsp cards and in-kernel driver.
Did it really work without problems?
Takashi
Takashi Iwai wrote:
At Tue, 12 May 2009 08:16:08 +0200, Raphaël Doursenaud wrote:
From: Raphaël Doursenaud rdoursenaud@free.fr
Allow the use of the FIRMWARE_IN_KERNEL option with hdsp cards and in-kernel driver.
Did it really work without problems?
Why load the digiface firmware? There's three different firmware files for three different io boxes, each has to get it's own firmware.
Flo
At Tue, 12 May 2009 08:44:26 +0200, Florian Faber wrote:
Takashi Iwai wrote:
At Tue, 12 May 2009 08:16:08 +0200, Raphaël Doursenaud wrote:
From: Raphaël Doursenaud rdoursenaud@free.fr
Allow the use of the FIRMWARE_IN_KERNEL option with hdsp cards and in-kernel driver.
Did it really work without problems?
Why load the digiface firmware?
Hmm, what are you looking at? The patch is irrelevant with the firmware choice...
There's three different firmware files for three different io boxes, each has to get it's own firmware.
It will.
Takashi
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Takashi Iwai a écrit :
At Tue, 12 May 2009 08:16:08 +0200, Raphaël Doursenaud wrote:
From: Raphaël Doursenaud rdoursenaud@free.fr
Allow the use of the FIRMWARE_IN_KERNEL option with hdsp cards and in-kernel driver.
Did it really work without problems?
Takashi
Tested over the weekend with two multifaces in my DAW. Got no problem. Hotplugging works: the firmware is reloaded on card access.
- -- Raphaël Doursenaud
At Tue, 12 May 2009 08:47:29 +0200, Raphaël Doursenaud wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Takashi Iwai a écrit :
At Tue, 12 May 2009 08:16:08 +0200, Raphaël Doursenaud wrote:
From: Raphaël Doursenaud rdoursenaud@free.fr
Allow the use of the FIRMWARE_IN_KERNEL option with hdsp cards and in-kernel driver.
Did it really work without problems?
Takashi
Tested over the weekend with two multifaces in my DAW. Got no problem.
Interesting. Did you build the firmware file into the kernel, or not?
Takashi
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Takashi Iwai a écrit :
At Tue, 12 May 2009 08:47:29 +0200, Raphaël Doursenaud wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Takashi Iwai a écrit :
At Tue, 12 May 2009 08:16:08 +0200, Raphaël Doursenaud wrote:
From: Raphaël Doursenaud rdoursenaud@free.fr
Allow the use of the FIRMWARE_IN_KERNEL option with hdsp cards and in-kernel driver.
Did it really work without problems?
Takashi
Tested over the weekend with two multifaces in my DAW. Got no problem.
Interesting. Did you build the firmware file into the kernel, or not?
Takashi
Yes I built all hdsp fimware files (multiface_firmware.bin multiface_firmware_rev11.bin digiface_firmware.bin digiface_firmware_rev11.bin) into the kernel. It's the aim of this patch. - -- Raphaël Doursenaud
participants (3)
-
Florian Faber -
Raphaël Doursenaud -
Takashi Iwai