[alsa-devel] [PATCH] ASoC: cs42l52: Fixes for Beep Volume kcontrol (fwd)
This patch reorders the min/max values for BEEP Volume. Also changes SOC_SINGLE_TLV to SOC_SINGLE_SX_TLV Add DB_SCALE beep_tlv for volume control
Signed-off-by: Brian Austin brian.austin@cirrus.com --- sound/soc/codecs/cs42l52.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c index 0f6f481..66d1e42 100644 --- a/sound/soc/codecs/cs42l52.c +++ b/sound/soc/codecs/cs42l52.c @@ -193,6 +193,8 @@ static DECLARE_TLV_DB_SCALE(mic_tlv, 1600, 100, 0);
static DECLARE_TLV_DB_SCALE(pga_tlv, -600, 50, 0);
+static DECLARE_TLV_DB_SCALE(beep_tlv, -5600, 200, 0); + static const unsigned int limiter_tlv[] = { TLV_DB_RANGE_HEAD(2), 0, 2, TLV_DB_SCALE_ITEM(-3000, 600, 0), @@ -449,7 +451,8 @@ static const struct snd_kcontrol_new cs42l52_snd_controls[] = { SOC_ENUM("Beep Pitch", beep_pitch_enum), SOC_ENUM("Beep on Time", beep_ontime_enum), SOC_ENUM("Beep off Time", beep_offtime_enum), - SOC_SINGLE_TLV("Beep Volume", CS42L52_BEEP_VOL, 0, 0x1f, 0x07, hl_tlv), + SOC_SINGLE_SX_TLV("Beep Volume", + CS42L52_BEEP_VOL, 0, 0x07, 0x1f, beep_tlv), SOC_SINGLE("Beep Mixer Switch", CS42L52_BEEP_TONE_CTL, 5, 1, 1), SOC_ENUM("Beep Treble Corner Freq", beep_treble_enum), SOC_ENUM("Beep Bass Corner Freq", beep_bass_enum),
On Mon, Aug 05, 2013 at 10:53:31AM -0500, Brian Austin wrote:
This patch reorders the min/max values for BEEP Volume. Also changes SOC_SINGLE_TLV to SOC_SINGLE_SX_TLV Add DB_SCALE beep_tlv for volume control
Can you split this into two paches please? The reordering is a bug fix which should go to the stable kernels but the new TLV isn't.
This patch reorders the min/max values for BEEP Volume. Also changes SOC_SINGLE_TLV to SOC_SINGLE_SX_TLV Add DB_SCALE beep_tlv for volume control
Can you split this into two paches please? The reordering is a bug fix which should go to the stable kernels but the new TLV isn't.
In trying to split up this patch wouldn't the TLV also be a bugfix? Currently it is using a scale that is not correct for this control. So really it seems this is 2 bug fixes in 1 patch. Correct? Shouldn't they both go to stable?
On Mon, Aug 05, 2013 at 01:21:05PM -0500, Brian Austin wrote:
In trying to split up this patch wouldn't the TLV also be a bugfix? Currently it is using a scale that is not correct for this control. So really it seems this is 2 bug fixes in 1 patch. Correct? Shouldn't they both go to stable?
Ah, the changelog said "add" not "replace existing incorrect" - yes they can both go to stable.
In trying to split up this patch wouldn't the TLV also be a bugfix? Currently it is using a scale that is not correct for this control. So really it seems this is 2 bug fixes in 1 patch. Correct? Shouldn't they both go to stable?
Ah, the changelog said "add" not "replace existing incorrect" - yes they can both go to stable.
OK. I sent them to alsa-devel. Is there somewhere else I should send them? It looks better in a series though.
Thanks
On Mon, Aug 05, 2013 at 01:47:13PM -0500, Brian Austin wrote:
OK. I sent them to alsa-devel. Is there somewhere else I should send them? It looks better in a series though.
I'm not seeing them? Just sending them as normal patches is enough, stable picks them up from git.
OK. I sent them to alsa-devel. Is there somewhere else I should send them? It looks better in a series though.
I'm not seeing them? Just sending them as normal patches is enough, stable picks them up from git.
I guess my git mailer is broke for some reason... I'll just forward these
participants (2)
-
Brian Austin
-
Mark Brown