Rockchip I2S commit possibly ignored
Hi Mark,
I was looking at Rockchip I2S commits and it seems "ASoC: rockchip: i2s: Reset the controller if soft reset failed" was supposed to have been merged to your sound.git but never was. I don't know if this was intentional or a real miss but in any case I'm letting you know.
According to 515b436be291ff197c52198282bbb19e79c9d197 'Merge series "Patches to update for rockchip i2s" from Sugar Zhang sugar.zhang@rock-chips.com:' it should have been merged to your tree. In rockchip-i2s.yaml there's even documentation that references the missing commit.
However in the alsa-devel archives, https://mailman.alsa-project.org/pipermail/alsa-devel/2021-August/189050.htm... I see there was no commit info for the unmerged patch. Perhaps this caused it to be black-holed?
Thanks, Geraldo Nascimento
On Tue, Aug 16, 2022 at 10:15:16AM -0300, Geraldo Nascimento wrote:
I was looking at Rockchip I2S commits and it seems "ASoC: rockchip: i2s: Reset the controller if soft reset failed" was supposed to have been merged to your sound.git but never was. I don't know if this was intentional or a real miss but in any case I'm letting you know.
Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
However in the alsa-devel archives, https://mailman.alsa-project.org/pipermail/alsa-devel/2021-August/189050.htm... I see there was no commit info for the unmerged patch. Perhaps this caused it to be black-holed?
If there was no commit info that means it wasn't applied.
On Tue, Aug 16, 2022 at 02:19:42PM +0100, Mark Brown wrote:
On Tue, Aug 16, 2022 at 10:15:16AM -0300, Geraldo Nascimento wrote:
I was looking at Rockchip I2S commits and it seems "ASoC: rockchip: i2s: Reset the controller if soft reset failed" was supposed to have been merged to your sound.git but never was. I don't know if this was intentional or a real miss but in any case I'm letting you know.
Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
This isn't my patch, it's a patch by Sugar Zhang from Rockchip that was supposed to have been applied one year ago, give or take 10 days. I can't resend a patch that wasn't authored by me.
Therefore I don't see the point of your complaint about "content free pings".
However in the alsa-devel archives, https://mailman.alsa-project.org/pipermail/alsa-devel/2021-August/189050.htm... I see there was no commit info for the unmerged patch. Perhaps this caused it to be black-holed?
If there was no commit info that means it wasn't applied.
That's what I thought. Cc:ing Sugar Zhang now.
On Tue, Aug 16, 2022 at 10:37:18AM -0300, Geraldo Nascimento wrote:
This isn't my patch, it's a patch by Sugar Zhang from Rockchip that was supposed to have been applied one year ago, give or take 10 days. I can't resend a patch that wasn't authored by me.
There's absolutely no problem with reposting someone else's patch - just add your Signed-off-by at the end of the signoff chain.
Therefore I don't see the point of your complaint about "content free pings".
In general the answer to "what's the status of this old patch?" is almost always going to be the same so there's a form letter for it, especially with such an old patch the chances of me having any recollection of what's going on are minimal.
On Tue, Aug 16, 2022 at 04:22:37PM +0100, Mark Brown wrote:
On Tue, Aug 16, 2022 at 10:37:18AM -0300, Geraldo Nascimento wrote:
This isn't my patch, it's a patch by Sugar Zhang from Rockchip that was supposed to have been applied one year ago, give or take 10 days. I can't resend a patch that wasn't authored by me.
There's absolutely no problem with reposting someone else's patch - just add your Signed-off-by at the end of the signoff chain.
Cool. I'm going to wait a couple of days to see if there's any interest from the side of Sugar Zhang of resending the patch with a proper commit message. If not, then I'll resend like you suggested. Thank you.
Therefore I don't see the point of your complaint about "content free pings".
In general the answer to "what's the status of this old patch?" is almost always going to be the same so there's a form letter for it, especially with such an old patch the chances of me having any recollection of what's going on are minimal.
I understand it.
Thank you, Geraldo Nascimento
participants (2)
-
Geraldo Nascimento -
Mark Brown