[alsa-devel] [PATCH 1/1] ASoC: mop500: Deletion of unnecessary checks before the function call "of_node_put"
From: Markus Elfring elfring@users.sourceforge.net Date: Tue, 2 Dec 2014 17:15:11 +0100
The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net --- sound/soc/ux500/mop500.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c index 7f7093b..4e0c0e5 100644 --- a/sound/soc/ux500/mop500.c +++ b/sound/soc/ux500/mop500.c @@ -63,10 +63,8 @@ static void mop500_of_node_put(void) int i;
for (i = 0; i < 2; i++) { - if (mop500_dai_links[i].cpu_of_node) - of_node_put(mop500_dai_links[i].cpu_of_node); - if (mop500_dai_links[i].codec_of_node) - of_node_put(mop500_dai_links[i].codec_of_node); + of_node_put(mop500_dai_links[i].cpu_of_node); + of_node_put(mop500_dai_links[i].codec_of_node); } }
On Tue, Dec 02, 2014 at 05:40:11PM +0100, SF Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Tue, 2 Dec 2014 17:15:11 +0100
The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This doesn't apply against current code, please check and resend.
On Tue, Dec 02, 2014 at 05:40:11PM +0100, SF Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Tue, 2 Dec 2014 17:15:11 +0100
The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
Sorry, realised what the dependency was - applied, thanks.
participants (2)
-
Mark Brown
-
SF Markus Elfring