[alsa-devel] [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
In case of failure in loading customize topology firmware, dfw_sst.bin gets loaded. However, current log provides this message as error even after successfully falling back to default topology "dfw_sst.bin".
Hence to convey proper message, changing log level and message.
Signed-off-by: Chintan Patel chintan.m.patel@intel.com --- sound/soc/intel/skylake/skl-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 22f768ca3c73..14dafa9f5b35 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
ret = request_firmware(&fw, skl->tplg_name, bus->dev); if (ret < 0) { - dev_err(bus->dev, "tplg fw %s load failed with %d\n", + dev_warn(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin", skl->tplg_name, ret); ret = request_firmware(&fw, "dfw_sst.bin", bus->dev); if (ret < 0) {
On Tue, 12 Sep 2017 21:54:58 +0200, Chintan Patel wrote:
In case of failure in loading customize topology firmware, dfw_sst.bin gets loaded. However, current log provides this message as error even after successfully falling back to default topology "dfw_sst.bin".
Hence to convey proper message, changing log level and message.
Is KERN_WARN the right level? I feel KERN_INFO suffices, since this is no error but the right behavior, after all.
Or is this an unexpected scenario that should be fixed in user side? In that case, KERN_WARN would be OK.
thanks,
Takashi
Signed-off-by: Chintan Patel chintan.m.patel@intel.com
sound/soc/intel/skylake/skl-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 22f768ca3c73..14dafa9f5b35 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
ret = request_firmware(&fw, skl->tplg_name, bus->dev); if (ret < 0) {
dev_err(bus->dev, "tplg fw %s load failed with %d\n",
dev_warn(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin", skl->tplg_name, ret);-- 1.9.1
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Hmm ... you are right. KERN_INFO make sense. Will re-submit it.
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Tuesday, September 12, 2017 1:47 PM To: Patel, Chintan M chintan.m.patel@intel.com Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
On Tue, 12 Sep 2017 21:54:58 +0200, Chintan Patel wrote:
In case of failure in loading customize topology firmware, dfw_sst.bin gets loaded. However, current log provides this message as error even after successfully falling back to default topology "dfw_sst.bin".
Hence to convey proper message, changing log level and message.
Is KERN_WARN the right level? I feel KERN_INFO suffices, since this is no error but the right behavior, after all.
Or is this an unexpected scenario that should be fixed in user side? In that case, KERN_WARN would be OK.
thanks,
Takashi
Signed-off-by: Chintan Patel chintan.m.patel@intel.com
sound/soc/intel/skylake/skl-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 22f768ca3c73..14dafa9f5b35 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
ret = request_firmware(&fw, skl->tplg_name, bus->dev); if (ret < 0) {
dev_err(bus->dev, "tplg fw %s load failed with %d\n",
dev_warn(bus->dev, "tplg fw %s load failed with %d, falling back to+dfw_sst.bin", skl->tplg_name, ret); ret = request_firmware(&fw, "dfw_sst.bin", bus->dev); if (ret < 0) { -- 1.9.1
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Please ignore this patch. I have submitted another patch.
Sorry for noise, was submitting first time here
-----Original Message----- From: Patel, Chintan M Sent: Tuesday, September 12, 2017 2:47 PM To: Takashi Iwai tiwai@suse.de Cc: alsa-devel@alsa-project.org Subject: RE: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
Hmm ... you are right. KERN_INFO make sense. Will re-submit it.
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Tuesday, September 12, 2017 1:47 PM To: Patel, Chintan M chintan.m.patel@intel.com Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
On Tue, 12 Sep 2017 21:54:58 +0200, Chintan Patel wrote:
In case of failure in loading customize topology firmware, dfw_sst.bin gets loaded. However, current log provides this message as error even after successfully falling back to default topology "dfw_sst.bin".
Hence to convey proper message, changing log level and message.
Is KERN_WARN the right level? I feel KERN_INFO suffices, since this is no error but the right behavior, after all.
Or is this an unexpected scenario that should be fixed in user side? In that case, KERN_WARN would be OK.
thanks,
Takashi
Signed-off-by: Chintan Patel chintan.m.patel@intel.com
sound/soc/intel/skylake/skl-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 22f768ca3c73..14dafa9f5b35 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
ret = request_firmware(&fw, skl->tplg_name, bus->dev); if (ret < 0) {
dev_err(bus->dev, "tplg fw %s load failed with %d\n",
dev_warn(bus->dev, "tplg fw %s load failed with %d, falling back to+dfw_sst.bin", skl->tplg_name, ret); ret = request_firmware(&fw, "dfw_sst.bin", bus->dev); if (ret < 0) { -- 1.9.1
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (3)
-
Chintan Patel -
Patel, Chintan M
-
Takashi Iwai