alsa-project/alsa-gobject pull request #50 was opened from takaswie:

The patchset is the part of work about #47.

Current implementation uses library-wide error domain to report error. this is partly against rule of GError usage. Furthermore, the error delivers information just about errno and hard to know the cause of error.

This patchset enhances error reporting. The library-wide error domain is obsoleted. A new error domain is added just for ALSASeq.UserClient. The error domain delivers information about the cause of error.

``` Takashi Sakamoto (15): seq: skip check of return value from g_malloc() seq: check whether method argument for GError is available seq: add checks for method arguments seq: user_client: just return when character device is not opened seq: add GLib enumeration to report type of error for ALSASeq.UserClient seq: user_client: add GQuark to report error for ALSASeq.UserClient seq: user_client: report error for ioctl seq: user_client: report open/write error seq: user_client: report error for port access permission seq: user_client: report error for queue access permission seq: user_client: update function comment for error reporting seq: query: use GFileError to report error seq: query: code refactoring to unify code to open file descriptor seq: query: code refactoring for error path seq: obsolete library-wide error quark

src/seq/alsaseq-enum-types.h | 14 ++ src/seq/alsaseq.map | 5 + src/seq/client-info.c | 20 +- src/seq/event-cntr.c | 341 +++++++++++++++++---------------- src/seq/privates.h | 6 - src/seq/query.c | 356 +++++++++++++++-------------------- src/seq/queue-status.c | 4 + src/seq/queue-tempo.c | 4 + src/seq/queue-timer.c | 4 + src/seq/remove-filter.c | 42 ++--- src/seq/user-client.c | 275 ++++++++++++++++++--------- src/seq/user-client.h | 4 + tests/alsaseq-enums | 7 + 13 files changed, 566 insertions(+), 516 deletions(-) ```

Request URL : https://github.com/alsa-project/alsa-gobject/pull/50 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/50.patch Repository URL: https://github.com/alsa-project/alsa-gobject