Re: [alsa-devel] [PATCH v3 4/8] x86: stop exporting msr-index.h to userland
Le 13/01/2017 à 16:43, David Howells a écrit :
-header-y += msr-index.h
I see it on my desktop as /usr/include/asm/msr-index.h and it's been there at least four years - and as such it's part of the UAPI. I don't think you can remove it unless you can guarantee there are no userspace users.
I keep it in the v2 of the series, but the maintainer, Borislav Petkov, asks me to un-export it.
I will follow the maintainer decision.
Regards, Nicolas
On Fri, Jan 13, 2017 at 05:08:34PM +0100, Nicolas Dichtel wrote:
Le 13/01/2017 à 16:43, David Howells a écrit :
-header-y += msr-index.h
I see it on my desktop as /usr/include/asm/msr-index.h and it's been there at least four years - and as such it's part of the UAPI. I don't think you can remove it unless you can guarantee there are no userspace users.
I keep it in the v2 of the series, but the maintainer, Borislav Petkov, asks me to un-export it.
I will follow the maintainer decision.
I'm not the maintainer. I simply think that exporting that file was wrong because it if we change something in it, we will break userspace. And that should not happen - if userspace needs MSRs, it should do its own defines.
participants (2)
-
Borislav Petkov -
Nicolas Dichtel