[alsa-devel] [PATCH 1/1] ASoC: fsi: Deletion of unnecessary checks before the function call "clk_disable"
From: Markus Elfring elfring@users.sourceforge.net Date: Tue, 2 Dec 2014 14:34:30 +0100
The clk_disable() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net --- sound/soc/sh/fsi.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c index 88e5df4..8869971 100644 --- a/sound/soc/sh/fsi.c +++ b/sound/soc/sh/fsi.c @@ -842,12 +842,9 @@ static int fsi_clk_disable(struct device *dev, return -EINVAL;
if (1 == clock->count--) { - if (clock->xck) - clk_disable(clock->xck); - if (clock->ick) - clk_disable(clock->ick); - if (clock->div) - clk_disable(clock->div); + clk_disable(clock->xck); + clk_disable(clock->ick); + clk_disable(clock->div); }
return 0;
On Tue, Dec 02, 2014 at 02:41:47PM +0100, SF Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Tue, 2 Dec 2014 14:34:30 +0100
The clk_disable() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
Applied, thanks.
participants (2)
-
Mark Brown
-
SF Markus Elfring