Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Enable VAG when DAC/ADC up
On Thu, Mar 29, 2012 at 03:17:00PM +0800, Zeng Zhaoming wrote:
So the code should be:
{"MIC_IN", NULL, "Mic Bias}, /* mic bias --> mic_in */ {"Capture Mux", "MIC_IN", "MIC_IN"}, /* mic_in --> adc_mux */
-+ {"Mic Bias", NULL, "MIC_IN"}, /* mic_in --> mic bias */ -+ {"Capture Mux", "MIC_IN", "Mic Bias"}, /* mic bias --> adc_mux */
and platform code
{"Mic Bias", NULL, "MIC"},
{"MIC_IN", NULL, "MIC"},
No, the bias should be a supply for the microphone - ensuring that this happens is the whole point of the patch I sent the other day.
On Thu, Mar 29, 2012 at 11:58:32AM +0100, Mark Brown wrote:
On Thu, Mar 29, 2012 at 03:17:00PM +0800, Zeng Zhaoming wrote:
So the code should be:
{"MIC_IN", NULL, "Mic Bias}, /* mic bias --> mic_in */ {"Capture Mux", "MIC_IN", "MIC_IN"}, /* mic_in --> adc_mux */
-+ {"Mic Bias", NULL, "MIC_IN"}, /* mic_in --> mic bias */ -+ {"Capture Mux", "MIC_IN", "Mic Bias"}, /* mic bias --> adc_mux */
and platform code
{"Mic Bias", NULL, "MIC"},
{"MIC_IN", NULL, "MIC"},
No, the bias should be a supply for the microphone - ensuring that this happens is the whole point of the patch I sent the other day.
The "MIC" above is confusing. I guess the following that I have in machine driver might be a little clearer.
{"Mic Bias", NULL, "Mic Jack"}, {"MIC_IN", NULL, "Mic Bias"},
And I need to present it in device tree though.
On Thu, Mar 29, 2012 at 10:04:23PM +0800, Shawn Guo wrote:
On Thu, Mar 29, 2012 at 11:58:32AM +0100, Mark Brown wrote:
No, the bias should be a supply for the microphone - ensuring that this happens is the whole point of the patch I sent the other day.
The "MIC" above is confusing. I guess the following that I have in machine driver might be a little clearer.
{"Mic Bias", NULL, "Mic Jack"}, {"MIC_IN", NULL, "Mic Bias"},
This should be something like:
{ "Mic Jack", NULL, "Mic Bias" }, { "MIC_IN", NULL, "Mic Bias" },
(with the conversion of Mic Bias to a supply widget) which has the bonus of being a whole lot easier to understand.
And I need to present it in device tree though.
Use the generic stuff that Stephen put into the core for reading machine driver routing maps out of the device tree (unless there's some problem with it, but it should work).
On Thu, Mar 29, 2012 at 03:10:20PM +0100, Mark Brown wrote: ...
This should be something like:
{ "Mic Jack", NULL, "Mic Bias" }, { "MIC_IN", NULL, "Mic Bias" },
(with the conversion of Mic Bias to a supply widget) which has the bonus of being a whole lot easier to understand.
Indeed. With your patch, Mic Bias is a supply widget now.
Hi Mark,
On Thu, Mar 29, 2012 at 10:10 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Thu, Mar 29, 2012 at 10:04:23PM +0800, Shawn Guo wrote:
On Thu, Mar 29, 2012 at 11:58:32AM +0100, Mark Brown wrote:
No, the bias should be a supply for the microphone - ensuring that this happens is the whole point of the patch I sent the other day.
The "MIC" above is confusing. I guess the following that I have in machine driver might be a little clearer.
{"Mic Bias", NULL, "Mic Jack"}, {"MIC_IN", NULL, "Mic Bias"},
This should be something like:
{ "Mic Jack", NULL, "Mic Bias" }, { "MIC_IN", NULL, "Mic Bias" },
"MiC Bias" --> "Mic Jack" should be enough. Why do we have "Mic Bias" --> "MIC_IN" ?
Thanks Richard
(with the conversion of Mic Bias to a supply widget) which has the bonus of being a whole lot easier to understand.
And I need to present it in device tree though.
Use the generic stuff that Stephen put into the core for reading machine driver routing maps out of the device tree (unless there's some problem with it, but it should work).
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On Wed, Apr 25, 2012 at 10:08:05AM +0800, Richard Zhao wrote:
{ "Mic Jack", NULL, "Mic Bias" }, { "MIC_IN", NULL, "Mic Bias" },
"MiC Bias" --> "Mic Jack" should be enough. Why do we have "Mic Bias" --> "MIC_IN" ?
Probably because I've misread what you're trying to do above - if it's just a single variation.
participants (3)
-
Mark Brown
-
Richard Zhao
-
Shawn Guo