Re: [alsa-devel] [alsa-cvslog] alsa-lib: Fix the state in snd_pcm_ioplug_pause()
Takashi Iwai tiwai@suse.de writes:
changeset: 2423:7388ad3d21ea tag: tip user: tiwai date: Mon Feb 25 15:11:46 2008 +0100 files: src/pcm/pcm_ioplug.c description: Fix the state in snd_pcm_ioplug_pause()
The states[] in snd_pcm_ioplug_pause() has wrong values. They should be swapped. ALSA bug#3796: https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3796
Aren't some bits missing from this bug report? (s/o->data->state = states[enable]/io->data->state = states[prev])
diff -r 6d83f965a9d9 -r 7388ad3d21ea src/pcm/pcm_ioplug.c --- a/src/pcm/pcm_ioplug.c Mon Feb 25 14:58:45 2008 +0100 +++ b/src/pcm/pcm_ioplug.c Mon Feb 25 15:11:46 2008 +0100 @@ -484,7 +484,7 @@ static int snd_pcm_ioplug_pause(snd_pcm_ { ioplug_priv_t *io = pcm->private_data; static snd_pcm_state_t states[2] = {
SND_PCM_STATE_PAUSED, SND_PCM_STATE_RUNNING
}; int prev, err;SND_PCM_STATE_RUNNING, SND_PCM_STATE_PAUSED
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Alsa-cvslog mailing list Alsa-cvslog@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/alsa-cvslog
At Mon, 25 Feb 2008 16:29:51 +0100, Thierry Vignaud wrote:
Takashi Iwai tiwai@suse.de writes:
changeset: 2423:7388ad3d21ea tag: tip user: tiwai date: Mon Feb 25 15:11:46 2008 +0100 files: src/pcm/pcm_ioplug.c description: Fix the state in snd_pcm_ioplug_pause()
The states[] in snd_pcm_ioplug_pause() has wrong values. They should be swapped. ALSA bug#3796: https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3796
Aren't some bits missing from this bug report? (s/o->data->state = states[enable]/io->data->state = states[prev])
No, the current code is correct.
Takashi
participants (2)
-
Takashi Iwai
-
Thierry Vignaud