Re: [alsa-devel] [PATCH 1/2] Echoaudio: Add support for Indigo express cards
Hi Giuliano,
At Mon, 16 Mar 2009 09:14:20 +0100 (CET), Giuliano Pochini wrote:
On Mon, 16 Mar 2009, Takashi Iwai wrote:
This patch adds support for IndigoIOx and IndigoDJx.
Signed-off-by Giuliano Pochini pochini@shiny.it
The code looks almost good, but could you do the following?
- split to two patches, one for kernel tree and one for alsa-driver
tree
There is a little problem: since about a month ago the git server is SLOWWW. It takes ages to download the alsa-kernel repository at 5KB/s :( I'll try from some server at work which stay on 24/7.
- run checkpatch.pl against the patch and fix issues reported there
Ok !
Any progress on this? I'm asking it because 2.6.29 kernel will likely go out soon, and all patches should be merged before the merge-window is opened.
If you have no time, either we skip it or I'll do a quick fix.
thanks,
Takashi
On Wed, 18 Mar 2009, Takashi Iwai wrote:
Hi Giuliano,
At Mon, 16 Mar 2009 09:14:20 +0100 (CET), Giuliano Pochini wrote:
On Mon, 16 Mar 2009, Takashi Iwai wrote:
This patch adds support for IndigoIOx and IndigoDJx.
Signed-off-by Giuliano Pochini pochini@shiny.it
The code looks almost good, but could you do the following?
- split to two patches, one for kernel tree and one for alsa-driver
tree
There is a little problem: since about a month ago the git server is SLOWWW. It takes ages to download the alsa-kernel repository at 5KB/s :( I'll try from some server at work which stay on 24/7.
- run checkpatch.pl against the patch and fix issues reported there
Ok !
Any progress on this? I'm asking it because 2.6.29 kernel will likely go out soon, and all patches should be merged before the merge-window is opened.
If you have no time, either we skip it or I'll do a quick fix.
I have little time except in the week end. Btw, I'll try to do the work this night.
-- Giuliano.
participants (2)
-
Giuliano Pochini
-
Takashi Iwai